driver::hid: Remove Mouse::getReport()

This function is completely unused, and should not have been exposed to begin
with. Neither in the base class, nor in specific implementations.

The `getReport()` method ties us to a specific report datatype, both in name,
and in shape. That's not something we want, we'd rather have the base class be
HID-library agnostic, which it can't be with `getReport()` present.

Luckily, the function is completely unused, and as such, is safe to remove
without deprecation.

Signed-off-by: Gergely Nagy <algernon@keyboard.io>
pull/1060/head
Gergely Nagy 4 years ago
parent f496aaa5d5
commit 894ca338de
No known key found for this signature in database
GPG Key ID: AC1E90BAC433F68F

@ -35,10 +35,6 @@ class NoMouse {
void press(uint8_t buttons) {} void press(uint8_t buttons) {}
void release(uint8_t buttons) {} void release(uint8_t buttons) {}
void click(uint8_t buttons) {} void click(uint8_t buttons) {}
HID_MouseReport_Data_t getReport() {
static HID_MouseReport_Data_t report;
return report;
}
}; };
struct MouseProps { struct MouseProps {

@ -76,9 +76,6 @@ class MouseWrapper {
void click(uint8_t buttons) { void click(uint8_t buttons) {
Mouse.click(buttons); Mouse.click(buttons);
} }
HID_MouseReport_Data_t getReport() {
return Mouse.getReport();
}
}; };
struct MouseProps: public base::MouseProps { struct MouseProps: public base::MouseProps {

Loading…
Cancel
Save