From 894ca338de59c4439da4abbf99f2672a4e4c51e5 Mon Sep 17 00:00:00 2001 From: Gergely Nagy Date: Thu, 10 Jun 2021 12:29:51 +0200 Subject: [PATCH] driver::hid: Remove Mouse::getReport() This function is completely unused, and should not have been exposed to begin with. Neither in the base class, nor in specific implementations. The `getReport()` method ties us to a specific report datatype, both in name, and in shape. That's not something we want, we'd rather have the base class be HID-library agnostic, which it can't be with `getReport()` present. Luckily, the function is completely unused, and as such, is safe to remove without deprecation. Signed-off-by: Gergely Nagy --- src/kaleidoscope/driver/hid/base/Mouse.h | 4 ---- src/kaleidoscope/driver/hid/keyboardio/Mouse.h | 3 --- 2 files changed, 7 deletions(-) diff --git a/src/kaleidoscope/driver/hid/base/Mouse.h b/src/kaleidoscope/driver/hid/base/Mouse.h index 268c2bb6..ebd71d3c 100644 --- a/src/kaleidoscope/driver/hid/base/Mouse.h +++ b/src/kaleidoscope/driver/hid/base/Mouse.h @@ -35,10 +35,6 @@ class NoMouse { void press(uint8_t buttons) {} void release(uint8_t buttons) {} void click(uint8_t buttons) {} - HID_MouseReport_Data_t getReport() { - static HID_MouseReport_Data_t report; - return report; - } }; struct MouseProps { diff --git a/src/kaleidoscope/driver/hid/keyboardio/Mouse.h b/src/kaleidoscope/driver/hid/keyboardio/Mouse.h index a177b468..f8773cd5 100644 --- a/src/kaleidoscope/driver/hid/keyboardio/Mouse.h +++ b/src/kaleidoscope/driver/hid/keyboardio/Mouse.h @@ -76,9 +76,6 @@ class MouseWrapper { void click(uint8_t buttons) { Mouse.click(buttons); } - HID_MouseReport_Data_t getReport() { - return Mouse.getReport(); - } }; struct MouseProps: public base::MouseProps {