refactoring Scanner

rust/src/compiler.rs

@@ -1,4 +1,4 @@
-use crate::scanner::{Scanner, TokenKind};
+use crate::scanner::Scanner;
 use color_eyre::eyre::Result;
 
 pub fn compile(source: &str) -> Result<()> {

rust/src/scanner.rs

@@ -4,6 +4,10 @@ pub struct Scanner<'a> {
     line: usize,
 }
 
+fn is_alpha(c: &char) -> bool {
+    c.is_ascii_alphabetic() || *c == '_'
+}
+
 impl<'a> Scanner<'a> {
     pub fn new(source: &'a str) -> Self {
         Self {
@@ -13,60 +17,32 @@ impl<'a> Scanner<'a> {
         }
     }
 
-    fn make_token(&self, kind: TokenKind) -> Token<'a> {
+    fn advance(&mut self) -> Option<char> {
-        Token {
-            kind,
-            value: std::str::from_utf8(&self.source[..self.current]).unwrap(),
-            line: self.line,
-        }
-    }
-
-    fn error_token(&self, message: &'static str) -> Token<'a> {
-        Token {
-            kind: TokenKind::Error,
-            value: message,
-            line: self.line,
-        }
-    }
-
-    fn advance(&mut self) -> char {
         self.current += 1;
-        self.source[self.current - 1] as char
+        self.source.get(self.current - 1).map(|&x| x as char)
     }
 
-    fn is_match(&mut self, expected: char) -> bool {
+    fn advance_if<F: Fn(&char) -> bool>(&mut self, f: F) -> bool {
-        if self.peek() != Some(expected) {
+        if matches!(self.peek(), Some(c) if f(&c)) {
-            return false;
+            self.current += 1;
+            true
+        } else {
+            false
         }
-
-        self.current += 1;
-        true
     }
 
     fn skip_whitespace(&mut self) {
         loop {
-            match self.peek() {
+            while self.advance_if(|&c| c == ' ' || c == '\r' || c == '\t') {}
-                Some(' ') | Some('\r') | Some('\t') => {
+
-                    self.advance();
+            if self.peek() == Some('/') && self.peek_next() == Some('/') {
-                    break;
+                while self.advance_if(|&c| c != '\n') {}
-                }
+            }
-                Some('\n') => {
+
-                    self.line += 1;
+            if self.advance_if(|&c| c == '\n') {
-                    self.advance();
+                self.line += 1;
-                    break;
+            } else {
-                }
+                return;
-                Some('/') => {
-                    if matches!(self.peek_next(), Some(c) if c == '/') {
-                        while matches!(self.peek(), Some(c) if c != '\n') {
-                            self.advance();
-                        }
-                    } else {
-                        return;
-                    }
-                }
-                _ => {
-                    return;
-                }
             }
         }
     }
@@ -75,49 +51,41 @@ impl<'a> Scanner<'a> {
         self.source.get(self.current).map(|&x| x as char)
     }
 
-    fn peek_next(&mut self) -> Option<char> {
+    fn peek_next(&self) -> Option<char> {
         self.source.get(self.current + 1).map(|&x| x as char)
     }
 
     fn string(&mut self) -> Token<'a> {
-        while matches!(self.peek(), Some(c) if c != '"') {
+        loop {
-            if self.peek() == Some('\n') {
+            match self.advance() {
-                self.line += 1;
+                Some('"') => break,
+                Some('\n') => {
+                    self.line += 1;
+                }
+                Some(_) => {}
+                None => return Token::error(self, "Unterminated string."),
             }
-            self.advance();
         }
 
-        if self.peek().is_none() {
+        Token::new(self, TokenKind::String)
-            // Maybe this should return an Err?
-            return self.error_token("Unterminated string.");
-        }
-
-        self.advance();
-        self.make_token(TokenKind::String)
     }
 
     fn number(&mut self) -> Token<'a> {
-        while matches!(self.peek(), Some(c) if c.is_ascii_digit()) {
+        while self.advance_if(char::is_ascii_digit) {}
-            self.advance();
-        }
 
         if self.peek() == Some('.') && matches!(self.peek_next(), Some(c) if c.is_ascii_digit()) {
             self.advance();
 
-            while matches!(self.peek(), Some(c) if c.is_ascii_digit()) {
+            while self.advance_if(char::is_ascii_digit) {}
-                self.advance();
-            }
         }
 
-        self.make_token(TokenKind::Number)
+        Token::new(self, TokenKind::Number)
     }
 
     fn identifier(&mut self) -> Token<'a> {
-        while matches!(self.peek(), Some(c) if is_alpha(c) || c.is_ascii_digit()) {
+        while self.advance_if(|c| is_alpha(c) || c.is_ascii_digit()) {}
-            self.advance();
-        }
 
-        self.make_token(self.identifier_type())
+        Token::new(self, self.identifier_type())
     }
 
     fn identifier_type(&self) -> TokenKind {
@@ -154,66 +122,87 @@ impl<'a> Iterator for Scanner<'a> {
 
     fn next(&mut self) -> Option<Self::Item> {
         self.skip_whitespace();
-        self.peek()?;
+
-
+        self.advance()
-        Some(match self.advance() {
+            .map(|c| match c {
-            c if is_alpha(c) => self.identifier(),
+                c if is_alpha(&c) => self.identifier(),
-            c if c.is_ascii_digit() => self.number(),
+                c if c.is_ascii_digit() => self.number(),
-            '(' => self.make_token(TokenKind::LeftParen),
+                '(' => Token::new(self, TokenKind::LeftParen),
-            ')' => self.make_token(TokenKind::RightParen),
+                ')' => Token::new(self, TokenKind::RightParen),
-            '{' => self.make_token(TokenKind::LeftBrace),
+                '{' => Token::new(self, TokenKind::LeftBrace),
-            '}' => self.make_token(TokenKind::RightBrace),
+                '}' => Token::new(self, TokenKind::RightBrace),
-            ';' => self.make_token(TokenKind::Semicolon),
+                ';' => Token::new(self, TokenKind::Semicolon),
-            ',' => self.make_token(TokenKind::Comma),
+                ',' => Token::new(self, TokenKind::Comma),
-            '.' => self.make_token(TokenKind::Dot),
+                '.' => Token::new(self, TokenKind::Dot),
-            '-' => self.make_token(TokenKind::Minus),
+                '-' => Token::new(self, TokenKind::Minus),
-            '+' => self.make_token(TokenKind::Plus),
+                '+' => Token::new(self, TokenKind::Plus),
-            '/' => self.make_token(TokenKind::Slash),
+                '/' => Token::new(self, TokenKind::Slash),
-            '*' => self.make_token(TokenKind::Star),
+                '*' => Token::new(self, TokenKind::Star),
-            '!' => {
+                '!' => {
-                if self.is_match('=') {
+                    if self.advance_if(|&c| c == '=') {
-                    self.make_token(TokenKind::BangEqual)
+                        Token::new(self, TokenKind::BangEqual)
-                } else {
+                    } else {
-                    self.make_token(TokenKind::Bang)
+                        Token::new(self, TokenKind::Bang)
+                    }
                 }
-            }
+                '=' => {
-            '=' => {
+                    if self.advance_if(|&c| c == '=') {
-                if self.is_match('=') {
+                        Token::new(self, TokenKind::EqualEqual)
-                    self.make_token(TokenKind::EqualEqual)
+                    } else {
-                } else {
+                        Token::new(self, TokenKind::Equal)
-                    self.make_token(TokenKind::Equal)
+                    }
                 }
-            }
+                '<' => {
-            '<' => {
+                    if self.advance_if(|&c| c == '=') {
-                if self.is_match('=') {
+                        Token::new(self, TokenKind::LessEqual)
-                    self.make_token(TokenKind::LessEqual)
+                    } else {
-                } else {
+                        Token::new(self, TokenKind::Less)
-                    self.make_token(TokenKind::Less)
+                    }
                 }
-            }
+                '>' => {
-            '>' => {
+                    if self.advance_if(|&c| c == '=') {
-                if self.is_match('=') {
+                        Token::new(self, TokenKind::GreaterEqual)
-                    self.make_token(TokenKind::GreaterEqual)
+                    } else {
-                } else {
+                        Token::new(self, TokenKind::Greater)
-                    self.make_token(TokenKind::Greater)
+                    }
                 }
-            }
+                '"' => self.string(),
-            '"' => self.string(),
+                _ => Token::error(self, "Unexpected character."),
-            _ => self.error_token("Unexpected character."),
+            })
-        })
+            .or({
+                Some(Token {
+                    kind: TokenKind::Eof,
+                    value: "",
+                    line: self.line,
+                })
+            })
     }
 }
 
-fn is_alpha(c: char) -> bool {
-    c.is_ascii_alphabetic() || c == '_'
-}
-
 pub struct Token<'a> {
     pub kind: TokenKind,
     pub value: &'a str,
     pub line: usize,
 }
 
+impl<'a> Token<'a> {
+    fn new(scanner: &Scanner<'a>, kind: TokenKind) -> Self {
+        Token {
+            kind,
+            value: std::str::from_utf8(&scanner.source[..scanner.current]).unwrap(),
+            line: scanner.line,
+        }
+    }
+
+    fn error(scanner: &Scanner, message: &'static str) -> Self {
+        Token {
+            kind: TokenKind::Error,
+            value: message,
+            line: scanner.line,
+        }
+    }
+}
+
 #[derive(Debug, PartialEq)]
 pub enum TokenKind {
     // Single-character tokens.
@@ -293,7 +282,7 @@ mod tests {
         assert_source_scan("fa", Some(TokenKind::Identifier));
 
         assert_source_scan("@", Some(TokenKind::Error));
-        assert_source_scan("", None);
+        assert_source_scan("", Some(TokenKind::Eof));
     }
 
     #[test]
@@ -301,14 +290,14 @@ mod tests {
         let mut scanner = Scanner::new("()");
         assert_scan(&mut scanner, Some(TokenKind::LeftParen));
         assert_scan(&mut scanner, Some(TokenKind::RightParen));
-        assert_scan(&mut scanner, None);
+        assert_scan(&mut scanner, Some(TokenKind::Eof));
     }
 
     #[test]
     fn test_whitespace() {
         assert_source_scan(" foo", Some(TokenKind::Identifier));
         assert_source_scan("\tfoo", Some(TokenKind::Identifier));
-        assert_source_scan("//   \n", None);
+        assert_source_scan("//   \n", Some(TokenKind::Eof));
     }
 
     fn assert_source_scan(source: &str, kind: Option<TokenKind>) {