You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Gergely Nagy 8ac4d9f5c1 A more efficient way to handle onFocusEvent commands ... In the past, we were using `Focus.handleHelp()` to see if we're handling a `help` command, and print the commands supported by the handler. We also used `strcmp_P` directly to compare (parts of) our input against command supported by the handler. This approach works, but had multiple major disadvantages: it duplicated strings between `handleHelp` and the `strcmp_P` calls, and it relied on fragile substring pointers to save space. To replace all that, this patch implements a different approach. Help handling is split between a check (`Focus.inputMatchesHelp()`) and a reply (`Focus.printHelp()`), the latter of which takes a list of `PSTR()` strings, rather than one single string. This allows us to reuse the same strings for comparing against the handler's input. The new approach no longer uses the fragile substring pointers, nor does it use `strcmp_P` directly, but goes through a wrapper (`Focus.inputMatchesCommand()`) instead. These changes lead to a more readable pattern. While we do use longer strings as a result, there is less duplication, and the new patterns also require less code, so we end up with saving space, at least on AVR devices. The old methods are still available and usable, but they're deprecated. Signed-off-by: Gergely Nagy <algernon@keyboard.io>		2 years ago
..
Kaleidoscope-AutoShift	A more efficient way to handle onFocusEvent commands	2 years ago
Kaleidoscope-CharShift	Convert static variables and functions to members	2 years ago
Kaleidoscope-Colormap	A more efficient way to handle onFocusEvent commands	2 years ago
Kaleidoscope-Cycle	Remove C-style `void` parameter for functions that don't take args	2 years ago
Kaleidoscope-CycleTimeReport	Rewrite CycleTimeReport plugin	2 years ago
Kaleidoscope-DefaultLEDModeConfig	A more efficient way to handle onFocusEvent commands	2 years ago
Kaleidoscope-Devel-ArduinoTrace	Remove C-style `void` parameter for functions that don't take args	2 years ago
Kaleidoscope-DynamicMacros	A more efficient way to handle onFocusEvent commands	2 years ago
Kaleidoscope-DynamicTapDance	A more efficient way to handle onFocusEvent commands	2 years ago
Kaleidoscope-EEPROM-Keymap	A more efficient way to handle onFocusEvent commands	2 years ago
Kaleidoscope-EEPROM-Keymap-Programmer	A more efficient way to handle onFocusEvent commands	2 years ago
Kaleidoscope-EEPROM-Settings	A more efficient way to handle onFocusEvent commands	2 years ago
Kaleidoscope-Escape-OneShot	A more efficient way to handle onFocusEvent commands	2 years ago
Kaleidoscope-FingerPainter	A more efficient way to handle onFocusEvent commands	2 years ago
Kaleidoscope-FirmwareDump	A more efficient way to handle onFocusEvent commands	2 years ago
Kaleidoscope-FirmwareVersion	A more efficient way to handle onFocusEvent commands	2 years ago
Kaleidoscope-FocusSerial	A more efficient way to handle onFocusEvent commands	2 years ago
Kaleidoscope-GhostInTheFirmware	Remove C-style `void` parameter for functions that don't take args	2 years ago
Kaleidoscope-Hardware-Dygma-Raise	A more efficient way to handle onFocusEvent commands	2 years ago
Kaleidoscope-Hardware-EZ-ErgoDox	Address spurious cpplint complaints	2 years ago
Kaleidoscope-Hardware-GD32-Eval	hardware: Fix the bootloader props on a number of devices	2 years ago
Kaleidoscope-Hardware-KBDFans-KBD4x	Format codebase with `clang-format`	3 years ago
Kaleidoscope-Hardware-Keyboardio-Atreus	hardware: Fix the bootloader props on a number of devices	2 years ago
Kaleidoscope-Hardware-Keyboardio-Imago	hardware: Fix the bootloader props on a number of devices	2 years ago
Kaleidoscope-Hardware-Keyboardio-Model01	hardware: Fix the bootloader props on a number of devices	2 years ago
Kaleidoscope-Hardware-Keyboardio-Model100	hardware: Fix the bootloader props on a number of devices	2 years ago
Kaleidoscope-Hardware-Model01	Add IWYU pragmas where necessary to keep or exclude selected headers	3 years ago
Kaleidoscope-Hardware-OLKB-Planck	Format codebase with `clang-format`	3 years ago
Kaleidoscope-Hardware-SOFTHRUF-Splitography	hardware: Fix the bootloader props on a number of devices	2 years ago
Kaleidoscope-Hardware-Technomancy-Atreus	hardware: Fix the bootloader props on a number of devices	2 years ago
Kaleidoscope-Hardware-gHeavy-ButterStick	Format codebase with `clang-format`	3 years ago
Kaleidoscope-Hardware-gHeavy-FaunchPad	Format codebase with `clang-format`	3 years ago
Kaleidoscope-HardwareTestMode	Remove C-style `void` parameter for functions that don't take args	2 years ago
Kaleidoscope-Heatmap	Heatmap: Make Heatmap data persist between LED effect changes	2 years ago
Kaleidoscope-HostOS	A more efficient way to handle onFocusEvent commands	2 years ago
Kaleidoscope-HostPowerManagement	Remove unnecessary constructor definitions	2 years ago
Kaleidoscope-IdleLEDs	A more efficient way to handle onFocusEvent commands	2 years ago
Kaleidoscope-LED-ActiveLayerColor	Remove C-style `void` parameter for functions that don't take args	2 years ago
Kaleidoscope-LED-ActiveModColor	Remove unnecessary constructor definitions	2 years ago
Kaleidoscope-LED-AlphaSquare	Remove C-style `void` parameter for functions that don't take args	2 years ago
Kaleidoscope-LED-Palette-Theme	A more efficient way to handle onFocusEvent commands	2 years ago
Kaleidoscope-LED-Stalker	Remove C-style `void` parameter for functions that don't take args	2 years ago
Kaleidoscope-LED-Wavepool	Remove C-style `void` parameter for functions that don't take args	2 years ago
Kaleidoscope-LEDControl	Get the two remaining files out of the plugins directory in docs to make it easier to ignore this dir	4 years ago
Kaleidoscope-LEDEffect-BootAnimation	Remove unnecessary constructor definitions	2 years ago
Kaleidoscope-LEDEffect-BootGreeting	Remove C-style `void` parameter for functions that don't take args	2 years ago
Kaleidoscope-LEDEffect-Breathe	Remove C-style `void` parameter for functions that don't take args	2 years ago
Kaleidoscope-LEDEffect-Chase	Remove C-style `void` parameter for functions that don't take args	2 years ago
Kaleidoscope-LEDEffect-Rainbow	Remove C-style `void` parameter for functions that don't take args	2 years ago
Kaleidoscope-LEDEffect-SolidColor	Remove C-style `void` parameter for functions that don't take args	2 years ago
Kaleidoscope-LEDEffects	Remove C-style `void` parameter for functions that don't take args	2 years ago
Kaleidoscope-LayerFocus	A more efficient way to handle onFocusEvent commands	2 years ago
Kaleidoscope-LayerNames	A more efficient way to handle onFocusEvent commands	2 years ago
Kaleidoscope-Leader	Remove C-style `void` parameter for functions that don't take args	2 years ago
Kaleidoscope-MacroSupport	Run IWYU on Macros, DynamicMacros, and MacroSupport code	2 years ago
Kaleidoscope-Macros	Run IWYU on Macros, DynamicMacros, and MacroSupport code	2 years ago
Kaleidoscope-MagicCombo	Update header includes and format code	2 years ago
Kaleidoscope-MouseKeys	fix example warp key mappings	2 years ago
Kaleidoscope-NumPad	Remove C-style `void` parameter for functions that don't take args	2 years ago
Kaleidoscope-OneShot	Remove unnecessary constructor definitions	2 years ago
Kaleidoscope-OneShotMetaKeys	Process Kaleidoscope with `iwyu.py`	3 years ago
Kaleidoscope-PersistentLEDMode	A more efficient way to handle onFocusEvent commands	2 years ago
Kaleidoscope-PrefixLayer	PrefixLayer: clear only modifiers during prefix	2 years ago
Kaleidoscope-Qukeys	Process Kaleidoscope with `iwyu.py`	3 years ago
Kaleidoscope-Ranges	Format codebase with `clang-format`	3 years ago
Kaleidoscope-Redial	Convert static variables and functions to members	2 years ago
Kaleidoscope-ShapeShifter	Replace C-style typedefs with idiomatic C++ code	2 years ago
Kaleidoscope-SpaceCadet	A more efficient way to handle onFocusEvent commands	2 years ago
Kaleidoscope-Steno	Remove unnecessary constructor definitions	2 years ago
Kaleidoscope-Syster	Update header includes and format code	2 years ago
Kaleidoscope-TapDance	Update header includes and format code	2 years ago
Kaleidoscope-TopsyTurvy	Convert static variables and functions to members	2 years ago
Kaleidoscope-Turbo	Update header includes and format code	2 years ago
Kaleidoscope-TypingBreaks	A more efficient way to handle onFocusEvent commands	2 years ago
Kaleidoscope-USB-Quirks	Remove unnecessary constructor definitions	2 years ago
Kaleidoscope-Unicode	Remove C-style `void` parameter for functions that don't take args	2 years ago
Kaleidoscope-WinKeyToggle	Remove unnecessary constructor definitions	2 years ago