cpplint: Ignore some casting warnings

In both cases, the warning is about a function argument that we do not use.
There's no benefit of doing a c++-style cast there, especially since they're
function arguments. In fact, doing anything else would just make the code less
readable. As such, we opt to ignore these warnings instead.

Signed-off-by: Gergely Nagy <algernon@keyboard.io>
pull/911/head
Gergely Nagy 4 years ago
parent b0586f3fc8
commit e9d2fd9637
No known key found for this signature in database
GPG Key ID: AC1E90BAC433F68F

@ -23,7 +23,7 @@ namespace plugin {
uint16_t AlphaSquareEffect::length = 1000; uint16_t AlphaSquareEffect::length = 1000;
AlphaSquareEffect::TransientLEDMode::TransientLEDMode(AlphaSquareEffect */*parent*/) AlphaSquareEffect::TransientLEDMode::TransientLEDMode(AlphaSquareEffect */*parent*/) // NOLINT(readability/casting)
: last_key_left_(Key_NoKey), : last_key_left_(Key_NoKey),
last_key_right_(Key_NoKey) last_key_right_(Key_NoKey)
{} {}

@ -62,7 +62,7 @@
METHOD_NAME ADD_TEMPLATE_BRACES(UNWRAP TMPL_PARAM_LIST) __NL__ \ METHOD_NAME ADD_TEMPLATE_BRACES(UNWRAP TMPL_PARAM_LIST) __NL__ \
), bool{} __NL__ \ ), bool{} __NL__ \
) __NL__ \ ) __NL__ \
test(int /* unused */) __NL__ \ test(int /* unused */) /* NOLINT(readability/casting) */ __NL__ \
{ __NL__ \ { __NL__ \
return true; __NL__ \ return true; __NL__ \
} __NL__ \ } __NL__ \
@ -75,4 +75,3 @@
__NL__ \ __NL__ \
static constexpr bool value = test<Class__>(int{}); __NL__ \ static constexpr bool value = test<Class__>(int{}); __NL__ \
}; };

Loading…
Cancel
Save