Introduce KaleidoscopePlugin.initialSetup, and deprecate .begin

As discussed in #196, if we are making `KaleidoscopePlugin.begin` protected, we
might as well give it a better name. That name is `initialSetup`, and this
change is the first step towards the migration. It introduces `initialSetup`
which will call `begin` for now, and deprecate `begin`, which is no longer an
abstract function.

Once everyone migrated to the new name, we can remove `.begin`, and turn
`.initialSetup` into an abstract function.

Signed-off-by: Gergely Nagy <kaleidoscope@gergo.csillger.hu>
pull/196/head
Gergely Nagy 7 years ago
parent 9182537fcf
commit de487990c3

@ -40,9 +40,34 @@ extern HARDWARE_IMPLEMENTATION KeyboardHardware;
class Kaleidoscope_; class Kaleidoscope_;
class KaleidoscopePlugin { class KaleidoscopePlugin {
friend Kaleidoscope_; friend class Kaleidoscope_;
protected: protected:
virtual void begin(void) = 0; /** @deprecated Initial setup function.
* Use \ref initialSetup() instead, and see documentation there.
*/
virtual void begin(void) __attribute__((deprecated("Use initialSetup() instead"))) { };
/** Initial plugin setup hook.
* All plugins are supposed to provide a singleton object, statically
* initialized at compile-time (with few exceptions). Because of this, the
* order in which they are instantiated is unspecified, and cannot be relied
* upon. For this reason, one's expected to explicitly initialize, "use" the
* plugins one wishes to, by calling `Kaleidoscope.use()` with a list of plugin
* object pointers.
*
* This function will in turn call the `initialSetup` function of each plugin,
* so that they can perform any initial setup they wish, such as registering
* event handler or loop hooks. This is the only time this function will be
* called. It is intentionally protected, and accessible by the `Kaleidoscope`
* class only.
*
* @TODO: Once the deprecated \ref begin() method is removed, turn this into an
* abstract function.
*/
virtual void initialSetup(void) {
begin();
}
}; };
class Kaleidoscope_ { class Kaleidoscope_ {
@ -64,7 +89,7 @@ class Kaleidoscope_ {
// Then, the one-argument version, that gives us type safety for a single // Then, the one-argument version, that gives us type safety for a single
// plugin. // plugin.
inline void use(KaleidoscopePlugin *p) { inline void use(KaleidoscopePlugin *p) {
p->begin(); p->initialSetup();
} }
// We have a no-op with a int argument, as a temporary hack until we remove // We have a no-op with a int argument, as a temporary hack until we remove

Loading…
Cancel
Save