cpplint: convert our TODOs to cpplint style

pull/911/head
Jesse Vincent 4 years ago committed by Gergely Nagy
parent 6724317991
commit cf4f9dab6d
No known key found for this signature in database
GPG Key ID: AC1E90BAC433F68F

@ -159,7 +159,7 @@ void ImagoLEDDriver::syncLeds() {
twi_writeTo(LED_DRIVER_ADDR, data, LED_REGISTER_DATA0_SIZE + 1, 1, 0); twi_writeTo(LED_DRIVER_ADDR, data, LED_REGISTER_DATA0_SIZE + 1, 1, 0);
// Don't reset "Last LED", because this is just us picking up from the last bank // Don't reset "Last LED", because this is just us picking up from the last bank
// TODO - we don't use all 117 LEDs on the Imago, so we can probably stop writing earlier // TODO(anyone) - we don't use all 117 LEDs on the Imago, so we can probably stop writing earlier
// Write the second LED bank // Write the second LED bank
// For space efficiency, we reuse the LED sending buffer // For space efficiency, we reuse the LED sending buffer

@ -206,7 +206,7 @@ void VirtualKeyScanner::readMatrix() {
} }
} }
} else { } else {
// TODO: Is there a device independent // TODO(anyone): Is there a device independent
// way to determine KeyAddr from key names? // way to determine KeyAddr from key names?
// key_addr = getRCfromPhysicalKey(token); // key_addr = getRCfromPhysicalKey(token);
// //

@ -310,7 +310,7 @@ class Keyboard {
if (!isModifierKey(released_key)) { if (!isModifierKey(released_key)) {
// TODO: this code is incomplete, but is better than nothing // TODO(anyone): this code is incomplete, but is better than nothing
// If we're toggling off the most recently toggled on key, clear // If we're toggling off the most recently toggled on key, clear
// last_keycode_toggled_on // last_keycode_toggled_on
if (last_keycode_toggled_on == released_key.getKeyCode()) { if (last_keycode_toggled_on == released_key.getKeyCode()) {
@ -424,7 +424,7 @@ class Keyboard {
// isModifierKey takes a Key and returns true if the key is a // isModifierKey takes a Key and returns true if the key is a
// keyboard key corresponding to a modifier like Control, Alt or Shift // keyboard key corresponding to a modifier like Control, Alt or Shift
// TODO: This function should be lifted to the Kaleidoscope core, somewhere. // TODO(anyone): This function should be lifted to the Kaleidoscope core, somewhere.
bool isModifierKey(Key key) { bool isModifierKey(Key key) {
// If it's not a keyboard key, return false // If it's not a keyboard key, return false

@ -57,7 +57,7 @@ EventHandlerResult FingerPainter::onKeyswitchEvent(Key &mapped_key, KeyAddr key_
if (!key_addr.isValid()) if (!key_addr.isValid())
return EventHandlerResult::EVENT_CONSUMED; return EventHandlerResult::EVENT_CONSUMED;
// TODO: The following works only for keyboards with LEDs for each key. // TODO(anyone): The following works only for keyboards with LEDs for each key.
uint8_t color_index = ::LEDPaletteTheme.lookupColorIndexAtPosition(color_base_, Runtime.device().getLedIndex(key_addr)); uint8_t color_index = ::LEDPaletteTheme.lookupColorIndexAtPosition(color_base_, Runtime.device().getLedIndex(key_addr));

Loading…
Cancel
Save