refactor to reuse some code and be a bit smarter about data.

Saves 324 bytes of PROGMEM and 265 bytes of RAM

src/Kaleidoscope-Model01-TestMode.cpp

@@ -45,7 +45,6 @@ void TestMode_::waitForKeypress() {
   for (auto temp = 0; temp < 16; temp++) {
     KeyboardHardware.readMatrix();
   }
-  delay(2);
   while (1) {
     KeyboardHardware.readMatrix();
     if (KeyboardHardware.leftHandState.all ==  R3C6
@@ -75,94 +74,61 @@ void TestMode_::test_leds(void) {
     LEDRainbowEffect.update();
     LEDControl.syncLeds();
   }
-  // set all the keys to red
+  waitForKeypress();
 }
 
 
-uint32_t leftBadKeys;
-uint32_t rightBadKeys;
-
-
-
-uint32_t cyclesSinceStateChange[64];
-
-
 
-void TestMode_::testMatrix() {
+void TestMode_::handleKeyEvent(side_data_t *side, keydata_t oldState, keydata_t newState, uint8_t row, uint8_t col, uint8_t col_offset) {
-  LEDControl.set_all_leds_to(200, 0, 0);
-  // Clear out the key event buffer so we don't get messed up information from
-  // taps during LED test mode.
-  for (auto temp = 0; temp < 16; temp++) {
-    KeyboardHardware.readMatrix();
-  }
-  // Reset bad keys from previous tests.
-  leftBadKeys = 0;
-  rightBadKeys = 0;
-  while (1) {
-    KeyboardHardware.readMatrix();
-    if (KeyboardHardware.leftHandState.all == TEST_MODE_KEY_COMBO) {
-      break;
-    }
-    for (byte row = 0; row < 4; row++) {
-      for (byte col = 0; col < 8; col++) {
   uint8_t keynum = (row * 8) + (col);
 
-        uint8_t keyState = ((bitRead(KeyboardHardware.previousLeftHandState.all, keynum) << 1) |
+  uint8_t keyState = ((bitRead(oldState.all, keynum) << 1) |
-                            (bitRead(KeyboardHardware.leftHandState.all,         keynum) << 0));
+                      (bitRead(newState.all,         keynum) << 0));
-
   if (keyState == TOGGLED_ON) {
-          if (cyclesSinceStateChange[keynum] < CHATTER_CYCLE_LIMIT) {
+    if (side->cyclesSinceStateChange[keynum] < CHATTER_CYCLE_LIMIT) {
-            bitSet(leftBadKeys, keynum);
+      bitSet(side->badKeys, keynum);
     }
-          cyclesSinceStateChange[keynum] = 0;
+    side->cyclesSinceStateChange[keynum] = 0;
-        } else if (cyclesSinceStateChange[keynum] <= CHATTER_CYCLE_LIMIT)  {
+  } else if (side->cyclesSinceStateChange[keynum] <= CHATTER_CYCLE_LIMIT)  {
-          cyclesSinceStateChange[keynum]++;
+    side->cyclesSinceStateChange[keynum]++;
-
   }
 
 
 
   // If the key is held down
   if (keyState == HELD) {
-          KeyboardHardware.setCrgbAt(row, 7 - col, green);
+    KeyboardHardware.setCrgbAt(row, col_offset - col, green);
   }
   // If we triggered chatter detection ever on this key
-        else if (bitRead(leftBadKeys, keynum) == 1) {
+  else if (bitRead(side->badKeys, keynum) == 1) {
-          KeyboardHardware.setCrgbAt(row, 7 - col, red);
+    KeyboardHardware.setCrgbAt(row, col_offset - col, red);
   }
 
   // If the key was just released
   else if (keyState == TOGGLED_OFF) {
-          KeyboardHardware.setCrgbAt(row, 7 - col, blue);
+    KeyboardHardware.setCrgbAt(row, col_offset - col, blue);
   }
+}
 
 
-        keyState = ((bitRead(KeyboardHardware.previousRightHandState.all, keynum) << 1) |
+void TestMode_::testMatrix() {
-                    (bitRead(KeyboardHardware.rightHandState.all,         keynum) << 0));
+  // Reset bad keys from previous tests.
-
+  side_data_t left = {{0}, 0};
-
+  side_data_t right = {{0}, 0};
-        if (keyState == TOGGLED_ON) {
-          if (cyclesSinceStateChange[keynum + 32] < CHATTER_CYCLE_LIMIT) {
-            bitSet(rightBadKeys, keynum);
-          }
-          cyclesSinceStateChange[keynum + 32] = 0;
-        } else if (cyclesSinceStateChange[keynum + 32] <= CHATTER_CYCLE_LIMIT)  {
-          cyclesSinceStateChange[keynum + 32]++;
-        }
 
-        // If the key is held down
-        if (keyState == HELD) {
-          KeyboardHardware.setCrgbAt(row, 15 - col, green);
-        }
-        // If we triggered chatter detection ever on this key
-        else if (bitRead(rightBadKeys, keynum) == 1) {
-          KeyboardHardware.setCrgbAt(row, 15 - col, red);
-        }
 
-        // If the key was just released
+  LEDControl.set_all_leds_to(200, 0, 0);
-        else if (keyState == TOGGLED_OFF) {
+  // Clear out the key event buffer so we don't get messed up information from
-          KeyboardHardware.setCrgbAt(row, 15 - col, blue);
+  // taps during LED test mode.
+  while (1) {
+    KeyboardHardware.readMatrix();
+    if (KeyboardHardware.leftHandState.all == TEST_MODE_KEY_COMBO) {
+      break;
     }
+    for (byte row = 0; row < 4; row++) {
+      for (byte col = 0; col < 8; col++) {
+        handleKeyEvent(&left, KeyboardHardware.previousLeftHandState, KeyboardHardware.leftHandState, row, col, 7);
+        handleKeyEvent(&right, KeyboardHardware.previousRightHandState, KeyboardHardware.leftHandState, row, col, 15);
       }
     }
     LEDControl.syncLeds();

src/Kaleidoscope-Model01-TestMode.h

@@ -5,6 +5,13 @@
 
 #define TEST_MODE_KEY_COMBO (R0C0 | R0C6 | R3C6)
 
+
+
+typedef struct {
+  uint8_t cyclesSinceStateChange[32];
+  uint32_t badKeys;
+
+} side_data_t;
 class TestMode_ : public KaleidoscopePlugin {
  public:
   TestMode_(void);
@@ -15,6 +22,7 @@ class TestMode_ : public KaleidoscopePlugin {
   static void test_leds();
   static void testMatrix();
   static void toggle_programming_leds_on();
+  static void handleKeyEvent(side_data_t *side, keydata_t oldState, keydata_t newState, uint8_t row, uint8_t col, uint8_t col_offset);
   static void waitForKeypress();
   static void loopHook(bool postClear);
   static void set_leds(uint8_t r, uint8_t g, uint8_t b);