cpplint: Ignore some false-positives for variable-sized arrays

All of these places use a template argument (usually indirectly) for array
sizes, so they are _not_ variable sized. It just so happens that cpplint is
unable to figure that out on its own. For this reason, mark them explicitly, and
let cpplint ignore these false positives.

Signed-off-by: Gergely Nagy <algernon@keyboard.io>
pull/911/head
Gergely Nagy 4 years ago
parent 24c3747ce6
commit ab535fc039
No known key found for this signature in database
GPG Key ID: AC1E90BAC433F68F

@ -86,10 +86,10 @@ class VirtualKeyScanner
bool read_matrix_enabled_; bool read_matrix_enabled_;
KeyState keystates_[matrix_rows * matrix_columns]; KeyState keystates_[matrix_rows * matrix_columns]; // NOLINT(runtime/arrays)
KeyState keystates_prev_[matrix_rows * matrix_columns]; KeyState keystates_prev_[matrix_rows * matrix_columns]; // NOLINT(runtime/arrays)
bool mask_[matrix_rows * matrix_columns]; bool mask_[matrix_rows * matrix_columns]; // NOLINT(runtime/arrays)
}; };
class VirtualLEDDriver class VirtualLEDDriver
@ -108,7 +108,7 @@ class VirtualLEDDriver
private: private:
cRGB led_states_[led_count]; cRGB led_states_[led_count]; // NOLINT(runtime/arrays)
}; };
// This overrides only the drivers and keeps the driver props of // This overrides only the drivers and keeps the driver props of

@ -80,7 +80,7 @@ class WS2812 {
} }
private: private:
Color leds_[ledCount]; Color leds_[ledCount]; // NOLINT(runtime/arrays)
uint8_t pinmask_; uint8_t pinmask_;
bool modified_ = false; bool modified_ = false;

@ -45,7 +45,7 @@ class KeyAddrEventQueue {
private: private:
uint8_t length_{0}; uint8_t length_{0};
KeyAddr addrs_[_capacity]; KeyAddr addrs_[_capacity];
_Timestamp timestamps_[_capacity]; _Timestamp timestamps_[_capacity]; // NOLINT(runtime/arrays)
_Bitfield release_event_bits_; _Bitfield release_event_bits_;
public: public:

Loading…
Cancel
Save