Refactoring. no functional changes

Signed-off-by: Jesse Vincent <jesse@keyboard.io>
pull/365/head
Jesse Vincent 6 years ago
parent b491146f33
commit 7c1a5cea95

@ -27,15 +27,15 @@ cRGB NumPad_::color = CRGB(160, 0, 0);
uint8_t NumPad_::lock_hue = 170; uint8_t NumPad_::lock_hue = 170;
kaleidoscope::EventHandlerResult NumPad_::onSetup(void) { kaleidoscope::EventHandlerResult NumPad_::onSetup(void) {
originalNumLockState = !!(kaleidoscope::hid::getKeyboardLEDs() & LED_NUM_LOCK); originalNumLockState = getNumlockState();
return kaleidoscope::EventHandlerResult::OK; return kaleidoscope::EventHandlerResult::OK;
} }
static bool getNumlockState() { bool NumPad_::getNumlockState() {
return !!(kaleidoscope::hid::getKeyboardLEDs() & LED_NUM_LOCK); return !!(kaleidoscope::hid::getKeyboardLEDs() & LED_NUM_LOCK);
} }
static void syncNumlock(bool state) { void NumPad_::syncNumlockState(bool state) {
bool numLockLEDState = getNumlockState(); bool numLockLEDState = getNumlockState();
if (numLockLEDState != state) { if (numLockLEDState != state) {
kaleidoscope::hid::pressKey(Key_KeypadNumLock); kaleidoscope::hid::pressKey(Key_KeypadNumLock);
@ -50,7 +50,7 @@ void NumPad_::cleanupNumlockState() {
LEDControl.set_mode(LEDControl.get_mode_index()); LEDControl.set_mode(LEDControl.get_mode_index());
if (!originalNumLockState) { if (!originalNumLockState) {
syncNumlock(false); syncNumlockState(false);
numLockLEDState = false; numLockLEDState = false;
} }
cleanupDone = true; cleanupDone = true;
@ -91,14 +91,12 @@ void NumPad_::setKeyboardLEDColors(void) {
kaleidoscope::EventHandlerResult NumPad_::afterEachCycle() { kaleidoscope::EventHandlerResult NumPad_::afterEachCycle() {
if (!Layer.isOn(numPadLayer)) { if (!Layer.isOn(numPadLayer)) {
cleanupNumlockState(); cleanupNumlockState();
return kaleidoscope::EventHandlerResult::OK; } else {
}
cleanupDone = false; cleanupDone = false;
syncNumlock(true); syncNumlockState(true);
setKeyboardLEDColors(); setKeyboardLEDColors();
}
return kaleidoscope::EventHandlerResult::OK; return kaleidoscope::EventHandlerResult::OK;
} }

@ -35,6 +35,8 @@ class NumPad_ : public kaleidoscope::Plugin {
void cleanupNumlockState(void); void cleanupNumlockState(void);
void setKeyboardLEDColors(void); void setKeyboardLEDColors(void);
bool getNumlockState(void);
void syncNumlockState(bool);
static uint8_t numpad_lock_key_row; static uint8_t numpad_lock_key_row;
static uint8_t numpad_lock_key_col; static uint8_t numpad_lock_key_col;

Loading…
Cancel
Save