Merge pull request #40 from algernon/f/hooks/additional-helpers

hooks: Add a way to replace hooks

src/KeyboardioFirmware.cpp

@@ -3,6 +3,8 @@
 byte NUMPAD_KEYMAP = 0;
 
 Keyboardio_::Keyboardio_(void) {
+    memset(eventHandlers, 0, HOOK_MAX * sizeof(custom_handler_t));
+    memset(loopHooks, 0, HOOK_MAX * sizeof(custom_handler_t));
 }
 
 void
@@ -20,7 +22,7 @@ Keyboardio_::setup(const byte keymap_count, const byte numpad_layer) {
     temporary_keymap = primary_keymap = Storage.load_primary_keymap(keymap_count);
 }
 
-custom_loop_t loopHooks[HOOK_MAX] = {NULL};
+custom_loop_t loopHooks[HOOK_MAX];
 
 void
 Keyboardio_::loop(void) {

src/hooks.cpp

@@ -1,27 +1,31 @@
 #include "hooks.h"
 
 void
-event_handler_hook_add (custom_handler_t hook) {
-    byte i;
-
-    for (i = 0; i < HOOK_MAX && eventHandlers[i] != NULL; i++) {
-    }
-
-    if (i == HOOK_MAX)
+event_handler_hook_replace (custom_handler_t oldHook, custom_handler_t newHook) {
+    for (byte i = 0; i < HOOK_MAX; i++) {
+        if (eventHandlers[i] == oldHook) {
+            eventHandlers[i] = newHook;
             return;
-
-    eventHandlers[i] = hook;
+        }
+    }
 }
 
 void
-loop_hook_add (custom_loop_t hook) {
-    byte i;
-
-    for (i = 0; i < HOOK_MAX && loopHooks[i] != NULL; i++) {
+event_handler_hook_add (custom_handler_t hook) {
+    event_handler_hook_replace ((custom_handler_t)NULL, hook);
 }
 
-    if (i == HOOK_MAX)
+void
+loop_hook_replace (custom_loop_t oldHook, custom_loop_t newHook) {
+    for (byte i = 0; i < HOOK_MAX; i++) {
+        if (loopHooks[i] == oldHook) {
+            loopHooks[i] = newHook;
             return;
+        }
+    }
+}
 
-    loopHooks[i] = hook;
+void
+loop_hook_add (custom_loop_t hook) {
+    loop_hook_replace ((custom_loop_t)NULL, hook);
 }

src/hooks.h

@@ -9,8 +9,10 @@ typedef bool (*custom_handler_t)(Key mappedKey, byte row, byte col, uint8_t curr
 extern custom_handler_t eventHandlers[HOOK_MAX];
 
 void event_handler_hook_add (custom_handler_t hook);
+void event_handler_hook_replace (custom_handler_t oldHook, custom_handler_t newHook);
 
 typedef void (*custom_loop_t)(void);
 extern custom_loop_t loopHooks[HOOK_MAX];
 
 void loop_hook_add (custom_loop_t hook);
+void loop_hook_replace (custom_loop_t oldHook, custom_loop_t newHook);

src/key_events.cpp

@@ -39,7 +39,7 @@ void handle_synthetic_key_event(Key mappedKey, uint8_t currentState, uint8_t pre
     }
 }
 
-custom_handler_t eventHandlers[HOOK_MAX] = {NULL};
+custom_handler_t eventHandlers[HOOK_MAX];
 
 Key lookup_key(byte keymap, byte row, byte col) {
     Key mappedKey;