Call the loop hooks after doing the other loop actions

Instead of calling loop hooks before anything else, including scanning
the matrix, call it after all that, at the end of `Keyboardio_::loop()`.
This is less surprising, and should not have any ill side-effects,
either.

(Based on a discussion with @obra on IRC.)

Signed-off-by: Gergely Nagy <algernon@madhouse-project.org>
pull/62/head
Gergely Nagy 8 years ago
parent 8fc7eb7727
commit 48ef882bf4

@ -21,14 +21,14 @@ custom_loop_t loopHooks[HOOK_MAX];
void void
Keyboardio_::loop(void) { Keyboardio_::loop(void) {
for (byte i = 0; loopHooks[i] != NULL && i < HOOK_MAX; i++) {
custom_loop_t hook = loopHooks[i];
(*hook)();
}
KeyboardHardware.scan_matrix(); KeyboardHardware.scan_matrix();
LEDControl.update(); LEDControl.update();
Keyboard.sendReport(); Keyboard.sendReport();
Keyboard.releaseAll(); Keyboard.releaseAll();
for (byte i = 0; loopHooks[i] != NULL && i < HOOK_MAX; i++) {
custom_loop_t hook = loopHooks[i];
(*hook)();
}
} }

Loading…
Cancel
Save