Remove deprecated `pressKey(key, toggled_on)` function

This function was mainly intended for internal use by Kaleidoscope's event
handling functions.  The logic that it used to provide is now handled by
`Runtime.handleKeyEvent()`, and it is not generally necessary or recommended for
plugin or sketch code to directly modify HID reports any longer.

Signed-off-by: Michael Richters <gedankenexperimenter@gmail.com>
pull/1115/head
Michael Richters 3 years ago
parent d0542ac6eb
commit 340d422a24
No known key found for this signature in database
GPG Key ID: 1288FD13E4EEF0C0

@ -1052,6 +1052,10 @@ The following headers and names have changed:
# Removed APIs # Removed APIs
#### `Keyboard::pressKey(Key key, bool toggled_on)`
This deprecated function was removed on **2022-03-03**. Its purpose was to handle rollover events for keys that include modifier flags, and that handling is now done elsewhere. Any code that called it should now simply call `Keyboard::pressKey(Key key)` instead, dropping the second argument.
#### Old layer key event handler functions #### Old layer key event handler functions
The deprecated `Layer.handleKeymapKeyswitchEvent()` function was removed on **2022-03-03**. Any code that called it should now call `Layer.handleLayerKeyEvent()` instead, with `event.addr` set to the appropriate `KeyAddr` value if possible, and `KeyAddr::none()` otherwise. The deprecated `Layer.handleKeymapKeyswitchEvent()` function was removed on **2022-03-03**. Any code that called it should now call `Layer.handleLayerKeyEvent()` instead, with `event.addr` set to the appropriate `KeyAddr` value if possible, and `KeyAddr::none()` otherwise.

@ -178,11 +178,6 @@ class Keyboard {
} }
} }
DEPRECATED(HID_KEYBOARD_PRESSKEY_TOGGLEDON)
void pressKey(Key pressed_key, bool toggled_on) __attribute__((noinline)) {
pressKey(pressed_key);
}
void pressKey(Key pressed_key) __attribute__((noinline)) { void pressKey(Key pressed_key) __attribute__((noinline)) {
pressModifiers(pressed_key); pressModifiers(pressed_key);
pressRawKey(pressed_key); pressRawKey(pressed_key);

@ -51,11 +51,3 @@
"every scan cycle, it should be moved to the `afterEachCycle()` event\n" __NL__ \ "every scan cycle, it should be moved to the `afterEachCycle()` event\n" __NL__ \
"handler instead.\n" __NL__ \ "handler instead.\n" __NL__ \
"This function will be removed after 2021-08-01." "This function will be removed after 2021-08-01."
#define _DEPRECATED_MESSAGE_HID_KEYBOARD_PRESSKEY_TOGGLEDON __NL__ \
"The `Keyboard::pressKey(key, toggled_on)` function is deprecated.\n" __NL__ \
"Please use `Keyboard::pressKey(key)` without the second argument\n" __NL__ \
"instead. The version with two arguments handled rollover events, and\n" __NL__ \
"this is now handled more completely by the event handling functions in\n" __NL__ \
"`Runtime`.\n" __NL__ \
"This function will be removed after 2021-08-01."

Loading…
Cancel
Save