Update Qukeys basic testcase for issue #970

Signed-off-by: Michael Richters <gedankenexperimenter@gmail.com>

tests/plugins/Qukeys/basic/common.h

@@ -26,6 +26,7 @@ namespace testing {
 constexpr uint16_t QUKEYS_HOLD_TIMEOUT = 200;
 constexpr uint8_t QUKEYS_OVERLAP_THRESHOLD = 90;
 constexpr uint8_t QUKEYS_MINIMUM_HOLD_TIME = 10;
+constexpr uint8_t QUKEYS_MIN_PRIOR_INTERVAL = 20;
 
 }
 }

tests/plugins/Qukeys/basic/sketch.ino

@@ -89,6 +89,7 @@ void setup() {
   Qukeys.setHoldTimeout(kaleidoscope::testing::QUKEYS_HOLD_TIMEOUT);
   Qukeys.setOverlapThreshold(kaleidoscope::testing::QUKEYS_OVERLAP_THRESHOLD);
   Qukeys.setMinimumHoldTime(kaleidoscope::testing::QUKEYS_MINIMUM_HOLD_TIME);
+  Qukeys.setMinimumPriorInterval(kaleidoscope::testing::QUKEYS_MIN_PRIOR_INTERVAL);
 
   Kaleidoscope.setup();
 }

tests/plugins/Qukeys/basic/test/testcase.cpp

@@ -39,9 +39,6 @@ class QukeysBasic : public VirtualDeviceTest {
 };
 
 TEST_F(QukeysBasic, TapQukeyAlone) {
-  // XXX Temporary workaround
-  sim_.RunForMillis(1000);
-
   // Press `A`
   sim_.Press(key_addr_A);
 
@@ -74,8 +71,8 @@ TEST_F(QukeysBasic, TapQukeyAlone) {
 }
 
 TEST_F(QukeysBasic, HoldQukeyAlone) {
-  // XXX Temporary workaround
+  // Prevent rapid typing suppression from affecting the test
-  sim_.RunForMillis(1000);
+  sim_.RunForMillis(QUKEYS_MIN_PRIOR_INTERVAL);
 
   // Press `A`
   sim_.Press(key_addr_A);
@@ -125,8 +122,8 @@ TEST_F(QukeysBasic, HoldQukeyAlone) {
 }
 
 TEST_F(QukeysBasic, FullOverlap) {
-  // XXX Temporary workaround
+  // Prevent rapid typing suppression from affecting the test
-  sim_.RunForMillis(1000);
+  sim_.RunForMillis(QUKEYS_MIN_PRIOR_INTERVAL);
 
   sim_.Press(key_addr_F);
   sim_.RunForMillis(20);
@@ -172,8 +169,8 @@ TEST_F(QukeysBasic, FullOverlap) {
 }
 
 TEST_F(QukeysBasic, RolloverPrimary) {
-  // XXX Temporary workaround
+  // Prevent rapid typing suppression from affecting the test
-  sim_.RunForMillis(1000);
+  sim_.RunForMillis(QUKEYS_MIN_PRIOR_INTERVAL);
 
   sim_.Press(key_addr_F);
   sim_.RunForMillis(20);