cpplint: Ignore some uses of `using namespace`

While `using namespace` certainly has its downsides, in these cases, the scope
is local to a single file, and makes the code _much_ more readable, offsetting
any downsides the directive otherwise has. As such, lets tell cpplint to ignore
these.

Signed-off-by: Gergely Nagy <algernon@keyboard.io>
pull/911/head
Gergely Nagy 4 years ago
parent 30eca52dce
commit 1f9f46d9f3
No known key found for this signature in database
GPG Key ID: AC1E90BAC433F68F

@ -44,7 +44,7 @@ KEYMAPS(
) )
/* *INDENT-ON* */ /* *INDENT-ON* */
using namespace kaleidoscope::sketch_exploration; using namespace kaleidoscope::sketch_exploration; // NOLINT(build/namespaces)
class BPlugin : public kaleidoscope::Plugin {}; class BPlugin : public kaleidoscope::Plugin {};
class CPlugin : public kaleidoscope::Plugin {}; class CPlugin : public kaleidoscope::Plugin {};

@ -29,7 +29,7 @@
namespace kaleidoscope { namespace kaleidoscope {
using namespace logging; using namespace logging; // NOLINT(build/namespaces)
// For each bit set in 'bitfield', output the corresponding string to 'stream' // For each bit set in 'bitfield', output the corresponding string to 'stream'
#define FOREACHBIT(bitfield, stream, str0, str1, str2, str3, str4, str5, str6, str7) \ #define FOREACHBIT(bitfield, stream, str0, str1, str2, str3, str4, str5, str6, str7) \

@ -53,7 +53,7 @@ namespace kaleidoscope {
namespace device { namespace device {
namespace virt { namespace virt {
using namespace kaleidoscope::logging; using namespace kaleidoscope::logging; // NOLINT(build/namespaces)
//############################################################################## //##############################################################################
// VirtualKeyScanner // VirtualKeyScanner

@ -19,7 +19,7 @@
#include "kaleidoscope_internal/LEDModeManager.h" #include "kaleidoscope_internal/LEDModeManager.h"
#include "kaleidoscope/keyswitch_state.h" #include "kaleidoscope/keyswitch_state.h"
using namespace kaleidoscope::internal; using namespace kaleidoscope::internal; // NOLINT(build/namespaces)
namespace kaleidoscope { namespace kaleidoscope {
namespace plugin { namespace plugin {

Loading…
Cancel
Save