c996c5e4e1
Minor code refactoring
...
In the Topsy case, pre-calculate `mapped_key.raw` for both branches, and only
modify its flags in the unishfted branch. This saves us about a dozen bytes of
PROGMEM.
Signed-off-by: Gergely Nagy <algernon@keyboard.io>
6 years ago
2ebf02d76a
Simplify the shift tracking
...
We do not need to track which shift is pressed, so lets use a bool instead of a
bitfield. Makes the shift checking code smaller too!
Signed-off-by: Gergely Nagy <algernon@keyboard.io>
6 years ago
f74292fbee
If a Topsy key is active, consume shifts
...
This allows us to reliably do the `Shift+TOPSY` case.
Fixes #11 .
Signed-off-by: Gergely Nagy <algernon@keyboard.io>
6 years ago
2bfd64a900
Simplify the "shifted" case too
...
Like in the unshifted case, avoid injecting keys, and fiddle with `mapped_key`
instead. This allows us to get rid of the `TOPSYTURVY` bitflag.
Signed-off-by: Gergely Nagy <algernon@keyboard.io>
6 years ago
1e0ac664fe
When seeing a modifier key, don't set last_pressed_position_
...
We do not want modifier keys to abort the TopsyTurvy magic.
Signed-off-by: Gergely Nagy <algernon@keyboard.io>
6 years ago
62f9fe481d
Simplify the normal, "unshifted" case
...
Instead of injecting a new event, modify `mapped_key` instead, and give it a
`SHIFT_HELD` flag.
Signed-off-by: Gergely Nagy <algernon@keyboard.io>
6 years ago
209a92b6e0
If a non-Topsy key toggles on, disable repeating the Topsy one
...
This is to avoid the case where chording a Topsy and a non-Topsy key would
result in both being repeated very fast. This happened because each cycle we
sent two reports: one for the Topsy key, one for the others. This didn't allow
the host's normal repeating behaviour to kick in, and instead, resulted in both
keys being input very fast.
Fixes #5 .
Signed-off-by: Gergely Nagy <algernon@keyboard.io>
6 years ago
8a426cc3e3
Drop the idle-case check
...
We're not calling `onKeyswitchEvent` in the idle cases anymore, drop the check
for a few bytes saved.
Signed-off-by: Gergely Nagy <algernon@keyboard.io>
6 years ago
d931ae1efa
Merge pull request #20 from keyboardio/bug/numlock-sync-report-spam
...
Bug/numlock sync report spam
6 years ago
e3acde9419
rename a variable that didn't match the style guide
...
Signed-off-by: Jesse Vincent <jesse@keyboard.io>
6 years ago
c6886b09fb
Change cleanupDone to numlockUnsynced to better represent what it does
...
Signed-off-by: Jesse Vincent <jesse@keyboard.io>
6 years ago
efbf158b13
Bring back the LED breathing effect
...
Signed-off-by: Jesse Vincent <jesse@keyboard.io>
6 years ago
8fb50b2415
Only run our "toggle numlock mode" once upon toggle of the layer
...
Signed-off-by: Jesse Vincent <jesse@keyboard.io>
6 years ago
79996b7216
Only try to reset the numlock led if we actually haven't done the
...
cleanup
Signed-off-by: Jesse Vincent <jesse@keyboard.io>
6 years ago
7c1a5cea95
Refactoring. no functional changes
...
Signed-off-by: Jesse Vincent <jesse@keyboard.io>
6 years ago
b491146f33
Extract a couple methods and rename a variable
...
Signed-off-by: Jesse Vincent <jesse@keyboard.io>
6 years ago
380a2e8a28
rename some variables to make them clearer
...
Signed-off-by: Jesse Vincent <jesse@keyboard.io>
6 years ago
d97b2060ba
The previous factoring just didn't work
6 years ago
8a33793a1c
Improve the 'port unwritable' error message
6 years ago
3a3281cb54
Clean up our flashing and warning messages.
...
Refactor the 'no bootloader port' message to only show up once, rather
than twice
6 years ago
edd671cd41
Quiet down linux USB port detection in cases where everything works ok
6 years ago
dda8787cf4
Merge pull request #8 from keyboardio/f/license-update-and-contributing
...
License clarification & CONTRIBUTING.md
6 years ago
1dfffc5ce6
Merge pull request #7 from keyboardio/f/license-update-and-contributing
...
License clarification & CONTRIBUTING.md
6 years ago
d3dfdae9fb
Merge pull request #11 from keyboardio/f/license-update-and-contributing
...
License clarification & CONTRIBUTING.md
6 years ago
7aecb267be
Merge pull request #4 from keyboardio/f/license-update-and-contributing
...
License clarification & CONTRIBUTING.md
6 years ago
aeb23a6395
Merge pull request #29 from keyboardio/f/license-update-and-contributing
...
License clarification & CONTRIBUTING.md
6 years ago
0990214206
Merge pull request #7 from keyboardio/f/license-update-and-contributing
...
License clarification & CONTRIBUTING.md
6 years ago
f112a1b0de
Merge pull request #27 from keyboardio/f/license-update-and-contributing
...
License clarification & CONTRIBUTING.md
6 years ago
f9e1578614
Merge pull request #19 from keyboardio/f/license-update-and-contributing
...
License clarification & CONTRIBUTING.md
6 years ago
b2ed2e4f0b
Merge pull request #14 from keyboardio/f/license-gpl3-only
...
Change the license to GPLv3-only
6 years ago
6eec3f44ee
Merge pull request #8 from keyboardio/f/license-update-and-contributing
...
License clarification & CONTRIBUTING.md
6 years ago
96fa782178
Relicense under the GPLv3 (only)
...
Signed-off-by: Gergely Nagy <algernon@keyboard.io>
6 years ago
2e8ac2a54b
Add CONTRIBUTING.md
...
Copied from Kaleidoscope, as it is applicable here too.
Signed-off-by: Gergely Nagy <algernon@keyboard.io>
6 years ago
b582edb52b
Assign my copyright to Keyboard.io
...
While the original plugin was written independently, significant developments
were made while working for Keyboard.io. As such, I feel it is appropriate to
assign copyright to the company.
Signed-off-by: Gergely Nagy <algernon@keyboard.io>
6 years ago
54b7a80967
Add CONTRIBUTING.md
...
Copied from Kaleidoscope, as it is applicable here too.
Signed-off-by: Gergely Nagy <algernon@keyboard.io>
6 years ago
358e58a6ef
Relicense under GPLv3 (only), and add headers.
...
Signed-off-by: Gergely Nagy <algernon@keyboard.io>
6 years ago
8d6fcb7c03
Add CONTRIBUTING.md
...
Copied from Kaleidoscope, as it is applicable here too.
Signed-off-by: Gergely Nagy <algernon@keyboard.io>
6 years ago
d769328104
Relicense under GPLv3 (only), and add headers.
...
Signed-off-by: Gergely Nagy <algernon@keyboard.io>
6 years ago
fcb06e201e
Add CONTRIBUTING.md
...
Copied from Kaleidoscope, as it is applicable here too.
Signed-off-by: Gergely Nagy <algernon@keyboard.io>
6 years ago
77bbc8e3df
Relicense under GPLv3 (only), and add headers.
...
Signed-off-by: Gergely Nagy <algernon@keyboard.io>
6 years ago
bd92587cdf
Add CONTRIBUTING.md
...
Copied from Kaleidoscope, as it is applicable here too.
Signed-off-by: Gergely Nagy <algernon@keyboard.io>
6 years ago
de1b71775d
Relicense under GPLv3 (only), and add headers.
...
Signed-off-by: Gergely Nagy <algernon@keyboard.io>
6 years ago
940d092664
Add CONTRIBUTING.md
...
Copied from Kaleidoscope, as it is applicable here too.
Signed-off-by: Gergely Nagy <algernon@keyboard.io>
6 years ago
bf1d5ddd39
Relicense under GPLv3 (only), and add headers.
...
Signed-off-by: Gergely Nagy <algernon@keyboard.io>
6 years ago
4d212c6f05
Add CONTRIBUTING.md
...
Copied from Kaleidoscope, as it is applicable here too.
Signed-off-by: Gergely Nagy <algernon@keyboard.io>
6 years ago
bfddd0a13c
Relicense under GPLv3 (only), and add headers.
...
Signed-off-by: Gergely Nagy <algernon@keyboard.io>
6 years ago
03739d27b0
Add CONTRIBUTING.md
...
Copied from Kaleidoscope, as it is applicable here too.
Signed-off-by: Gergely Nagy <algernon@keyboard.io>
6 years ago
0e30f74210
Relicense under GPLv3 (only), and add headers.
...
Signed-off-by: Gergely Nagy <algernon@keyboard.io>
6 years ago
895679f231
Add CONTRIBUTING.md
...
Copied from Kaleidoscope, as it is applicable here too.
Signed-off-by: Gergely Nagy <algernon@keyboard.io>
6 years ago
8e19770508
Relicense under GPLv3 (only), and add headers.
...
Signed-off-by: Gergely Nagy <algernon@keyboard.io>
6 years ago
Gergely Nagy
Jesse Vincent
Jesse Vincent