Kaleidoscope

Commit Graph

Author	SHA1	Message	Date
Michael Richters	9b04d6663c	Run IWYU (with the new tools) on test simulator code This mixes some manual work (IWYU pragmas, a better solution to the Arduino preprocessor macros problem) with automated running of the tools. At this point, it would be too much work to separate these into distinct commits, and there isn't that much value to doing so. There are still some things we could do to make things more robust, as some of the headers need to be in a certain order, which happens to be in the same sort order used by IWYU (`testing/*` files need to come after certain headers than include `Arduino.h`), but it's probably not worth the clutter of adding an `#if 1` just to stop IWYU from re-ordering them. I tried to get `#pragma push_macro("max")/pop_macro("max")` to work, but ended up getting completely nonsensical compilation errors, so I gave up on it. Signed-off-by: Michael Richters <gedankenexperimenter@gmail.com>	3 years ago
Michael Richters	e5d67efd58	Format codebase with `clang-format` Signed-off-by: Michael Richters <gedankenexperimenter@gmail.com>	3 years ago
Gergely Nagy	f32f845d97	tests: Add a failing testcase for #951 This adds a test to check that `Layer.isActive(0)` should return true, without explicitly activating layer 0. At the moment, this is not the case, and the test will fail. Signed-off-by: Gergely Nagy <algernon@keyboard.io>	4 years ago

Author

SHA1

Message

Date

Michael Richters

9b04d6663c

Run IWYU (with the new tools) on test simulator code

This mixes some manual work (IWYU pragmas, a better solution to the Arduino
preprocessor macros problem) with automated running of the tools.  At this
point, it would be too much work to separate these into distinct commits, and
there isn't that much value to doing so.

There are still some things we could do to make things more robust, as some of
the headers need to be in a certain order, which happens to be in the same sort
order used by IWYU (`testing/*` files need to come after certain headers than
include `Arduino.h`), but it's probably not worth the clutter of adding an `#if
1` just to stop IWYU from re-ordering them.

I tried to get `#pragma push_macro("max")/pop_macro("max")` to work, but ended
up getting completely nonsensical compilation errors, so I gave up on it.

Signed-off-by: Michael Richters <gedankenexperimenter@gmail.com>

Michael Richters

e5d67efd58

Format codebase with `clang-format`

Signed-off-by: Michael Richters <gedankenexperimenter@gmail.com>

Gergely Nagy

f32f845d97

tests: Add a failing testcase for #951

This adds a test to check that `Layer.isActive(0)` should return true, without
explicitly activating layer 0. At the moment, this is not the case, and the test
will fail.

Signed-off-by: Gergely Nagy <algernon@keyboard.io>

3 Commits (a960f5a0cb9276f6ff0235a07ba192460e437b12)