Kaleidoscope

Commit Graph

Author	SHA1	Message	Date
Gergely Nagy	1d65c02f9f	hardware/ATMegaKeyboard: Don't hardcode the list of keyboards Instead of guarding the ATMegaKeyboard files with an `#if` that hard-coded which keyboards are based on the class, guard them with `KALEIDOSCOPE_WITH_ATMEGA_KEYBOARD`, set by the main hardware headers. Those headers get included early, and are as such, a perfect way to guard these things. This way if we add a new keyboard using the base class, we don't have to modify the base class itself, and the new hardware plugin can be entirely self-contained. Signed-off-by: Gergely Nagy <algernon@keyboard.io>	6 years ago
Jesse Vincent	d96ac86454	A first pass implementation for AVR-based OLKB Planck keyboards Signed-off-by: Jesse Vincent <jesse@keyboard.io>	6 years ago

Author

SHA1

Message

Date

Gergely Nagy

1d65c02f9f

hardware/ATMegaKeyboard: Don't hardcode the list of keyboards

Instead of guarding the ATMegaKeyboard files with an `#if` that hard-coded which
keyboards are based on the class, guard them with
`KALEIDOSCOPE_WITH_ATMEGA_KEYBOARD`, set by the main hardware headers. Those
headers get included early, and are as such, a perfect way to guard these
things.

This way if we add a new keyboard using the base class, we don't have to modify
the base class itself, and the new hardware plugin can be entirely self-contained.

Signed-off-by: Gergely Nagy <algernon@keyboard.io>

Jesse Vincent

d96ac86454

A first pass implementation for AVR-based OLKB Planck keyboards

Signed-off-by: Jesse Vincent <jesse@keyboard.io>

2 Commits (5fe12de4dd287cd1f07d38f88256e08e2479ab31)