Kaleidoscope

Commit Graph

Author	SHA1	Message	Date
Gergely Nagy	2e21af99b9	Implement a Hardware base class This is basically the old Kaleidoscope-Hardware plugin pulled in, and made into a base class. The purpose is documentation (#167) mostly. The base class has default implementations for all methods (most do nothing), and can be overridden by derived classes. Since the hardware object is always going to be called through `KeyboardHardware`, which has the exact type of the hardware, we do not need to use virtual functions. The derived class will just shadow the default implementations. All hardware plugins were updated to use this (directly or indirectly). The resulting compiled binary is the same, but we were able to remove a few boilerplate lines from here and there. Signed-off-by: Gergely Nagy <algernon@keyboard.io>	6 years ago

Author

SHA1

Message

Date

Gergely Nagy

2e21af99b9

Implement a Hardware base class

This is basically the old Kaleidoscope-Hardware plugin pulled in, and made into
a base class. The purpose is documentation (#167) mostly. The base class has
default implementations for all methods (most do nothing), and can be overridden
by derived classes. Since the hardware object is always going to be called
through `KeyboardHardware`, which has the exact type of the hardware, we do not
need to use virtual functions. The derived class will just shadow the default
implementations.

All hardware plugins were updated to use this (directly or indirectly). The
resulting compiled binary is the same, but we were able to remove a few
boilerplate lines from here and there.

Signed-off-by: Gergely Nagy <algernon@keyboard.io>

1 Commits (2e21af99b9cf1e51c26b844f65f6d03500159fc7)