From f870bde2fc591da8e4d8aac6dc0e0371f8707506 Mon Sep 17 00:00:00 2001 From: Gergely Nagy Date: Thu, 1 Oct 2020 10:21:48 +0200 Subject: [PATCH] cpplint: Ignore incomplete declaration of namespaces Within some of the internal headers, we do not have a complete declaration of some namespaces, and that's ok. Most of these cases are within macros anyway. Since there's no sane way to make cpplint happy otherwise, lets ignore these warnings instead. Signed-off-by: Gergely Nagy --- src/kaleidoscope_internal/LEDModeManager.h | 6 +++--- .../sketch_exploration/keymap_exploration.h | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/kaleidoscope_internal/LEDModeManager.h b/src/kaleidoscope_internal/LEDModeManager.h index 4d614145..8568bf0b 100644 --- a/src/kaleidoscope_internal/LEDModeManager.h +++ b/src/kaleidoscope_internal/LEDModeManager.h @@ -405,9 +405,9 @@ class LEDModeManager { LEDModeManager::setupLEDMode(&::PLUGIN); #define _INIT_LED_MODE_MANAGER(...) \ - namespace kaleidoscope { __NL__ \ - namespace internal { __NL__ \ - namespace led_mode_management { __NL__ \ + namespace kaleidoscope { /* NOLINT(build/namespaces) */ __NL__ \ + namespace internal { /* NOLINT(build/namespaces) */ __NL__ \ + namespace led_mode_management { /* NOLINT(build/namespaces) */ __NL__ \ __NL__ \ /* Setup the array-like data structure that stores __NL__ \ * LEDModeFactories */ __NL__ \ diff --git a/src/kaleidoscope_internal/sketch_exploration/keymap_exploration.h b/src/kaleidoscope_internal/sketch_exploration/keymap_exploration.h index 34ce8d55..d5ad3f86 100644 --- a/src/kaleidoscope_internal/sketch_exploration/keymap_exploration.h +++ b/src/kaleidoscope_internal/sketch_exploration/keymap_exploration.h @@ -18,8 +18,8 @@ #include "kaleidoscope/key_defs.h" -namespace kaleidoscope { -namespace sketch_exploration { +namespace kaleidoscope { // NOLINT(build/namespaces) +namespace sketch_exploration { // NOLINT(build/namespaces) // A simple keymap adaptor class that makes the keymap conveniently accessible. // at compiletime. @@ -214,7 +214,7 @@ extern void pluginsExploreSketch(); // exploreSketch<_Sketch>(...)-hook. // #define _INIT_KEYMAP_EXPLORATION \ - namespace kaleidoscope { \ + namespace kaleidoscope { /* NOLINT(build/namespaces) */ \ namespace sketch_exploration { \ \ template \