DynamicMacros: Make sure we keep within bounds during play

Caught by @gedankenexperimenter, thanks! Signed-off-by: Gergely Nagy <algernon@keyboard.io>
3 years ago · d29ffa72dc
parent 39e607e7c7
commit d29ffa72dc
1 changed files with 1 additions and 1 deletions
--- a/plugins/Kaleidoscope-DynamicMacros/src/kaleidoscope/plugin/DynamicMacros.cpp
+++ b/plugins/Kaleidoscope-DynamicMacros/src/kaleidoscope/plugin/DynamicMacros.cpp
@ -141,7 +141,7 @@ void DynamicMacros::play(uint8_t macro_id) {

  pos = storage_base_ + map_[macro_id];

-  while (true) {
+  while (pos < storage_base_ + storage_size_) {
    switch (macro = Runtime.storage().read(pos++)) {
    case MACRO_ACTION_STEP_EXPLICIT_REPORT:
    case MACRO_ACTION_STEP_IMPLICIT_REPORT: