From cc135a7eb7cce167fb113f6987cfc39fbf3c20ab Mon Sep 17 00:00:00 2001 From: Jesse Vincent Date: Wed, 30 Sep 2020 20:22:40 -0700 Subject: [PATCH] cpplint fix for " "virtual" is redundant since function is already declared as "final" [readability/inheritance] [4]" --- src/kaleidoscope/plugin/Colormap.h | 4 ++-- src/kaleidoscope/plugin/Heatmap.h | 2 +- src/kaleidoscope/plugin/LED-ActiveLayerColor.h | 4 ++-- src/kaleidoscope/plugin/LED-Stalker.h | 2 +- src/kaleidoscope/plugin/LED-Wavepool.h | 2 +- src/kaleidoscope/plugin/LEDEffect-Breathe.h | 2 +- src/kaleidoscope/plugin/LEDEffect-Chase.h | 2 +- src/kaleidoscope/plugin/LEDEffect-Rainbow.h | 4 ++-- src/kaleidoscope/plugin/LEDEffect-SolidColor.h | 4 ++-- src/kaleidoscope/plugin/TriColor.h | 2 +- 10 files changed, 14 insertions(+), 14 deletions(-) diff --git a/src/kaleidoscope/plugin/Colormap.h b/src/kaleidoscope/plugin/Colormap.h index 0ee38399..0389792b 100644 --- a/src/kaleidoscope/plugin/Colormap.h +++ b/src/kaleidoscope/plugin/Colormap.h @@ -48,8 +48,8 @@ class ColormapEffect : public Plugin, friend class ColormapEffect; - virtual void onActivate(void) final; - virtual void refreshAt(KeyAddr key_addr) final; + void onActivate(void) final; + void refreshAt(KeyAddr key_addr) final; private: const ColormapEffect *parent_; diff --git a/src/kaleidoscope/plugin/Heatmap.h b/src/kaleidoscope/plugin/Heatmap.h index 829d6dd3..6a27bc48 100644 --- a/src/kaleidoscope/plugin/Heatmap.h +++ b/src/kaleidoscope/plugin/Heatmap.h @@ -53,7 +53,7 @@ class Heatmap : public Plugin, protected: - virtual void update() final; + void update() final; private: diff --git a/src/kaleidoscope/plugin/LED-ActiveLayerColor.h b/src/kaleidoscope/plugin/LED-ActiveLayerColor.h index b5363131..a865207d 100644 --- a/src/kaleidoscope/plugin/LED-ActiveLayerColor.h +++ b/src/kaleidoscope/plugin/LED-ActiveLayerColor.h @@ -43,8 +43,8 @@ class LEDActiveLayerColorEffect : public Plugin, protected: - virtual void onActivate(void) final; - virtual void refreshAt(KeyAddr key_addr) final; + void onActivate(void) final; + void refreshAt(KeyAddr key_addr) final; private: diff --git a/src/kaleidoscope/plugin/LED-Stalker.h b/src/kaleidoscope/plugin/LED-Stalker.h index 9642983d..db099e94 100644 --- a/src/kaleidoscope/plugin/LED-Stalker.h +++ b/src/kaleidoscope/plugin/LED-Stalker.h @@ -54,7 +54,7 @@ class StalkerEffect : public Plugin, protected: - virtual void update() final; + void update() final; private: diff --git a/src/kaleidoscope/plugin/LED-Wavepool.h b/src/kaleidoscope/plugin/LED-Wavepool.h index e52d3081..d52b40d1 100644 --- a/src/kaleidoscope/plugin/LED-Wavepool.h +++ b/src/kaleidoscope/plugin/LED-Wavepool.h @@ -57,7 +57,7 @@ class WavepoolEffect : public Plugin, protected: - virtual void update() final; + void update() final; private: diff --git a/src/kaleidoscope/plugin/LEDEffect-Breathe.h b/src/kaleidoscope/plugin/LEDEffect-Breathe.h index d6128975..ee99ef04 100644 --- a/src/kaleidoscope/plugin/LEDEffect-Breathe.h +++ b/src/kaleidoscope/plugin/LEDEffect-Breathe.h @@ -41,7 +41,7 @@ class LEDBreatheEffect : public Plugin, : parent_(parent) {} protected: - virtual void update(void) final; + void update(void) final; private: diff --git a/src/kaleidoscope/plugin/LEDEffect-Chase.h b/src/kaleidoscope/plugin/LEDEffect-Chase.h index 912f9624..0ccb4400 100644 --- a/src/kaleidoscope/plugin/LEDEffect-Chase.h +++ b/src/kaleidoscope/plugin/LEDEffect-Chase.h @@ -52,7 +52,7 @@ class LEDChaseEffect : public Plugin, protected: - virtual void update() final; + void update() final; private: diff --git a/src/kaleidoscope/plugin/LEDEffect-Rainbow.h b/src/kaleidoscope/plugin/LEDEffect-Rainbow.h index 750fe43e..1d454561 100644 --- a/src/kaleidoscope/plugin/LEDEffect-Rainbow.h +++ b/src/kaleidoscope/plugin/LEDEffect-Rainbow.h @@ -46,7 +46,7 @@ class LEDRainbowEffect : public Plugin, TransientLEDMode(const LEDRainbowEffect *parent) : parent_(parent) {} - virtual void update() final; + void update() final; private: @@ -91,7 +91,7 @@ class LEDRainbowWaveEffect : public Plugin, public LEDModeInterface { TransientLEDMode(const LEDRainbowWaveEffect *parent) : parent_(parent) {} - virtual void update() final; + void update() final; private: diff --git a/src/kaleidoscope/plugin/LEDEffect-SolidColor.h b/src/kaleidoscope/plugin/LEDEffect-SolidColor.h index 2678b2fb..64527431 100644 --- a/src/kaleidoscope/plugin/LEDEffect-SolidColor.h +++ b/src/kaleidoscope/plugin/LEDEffect-SolidColor.h @@ -41,8 +41,8 @@ class LEDSolidColor : public Plugin, : parent_(parent) {} protected: - virtual void onActivate(void) final; - virtual void refreshAt(KeyAddr key_addr) final; + void onActivate(void) final; + void refreshAt(KeyAddr key_addr) final; private: diff --git a/src/kaleidoscope/plugin/TriColor.h b/src/kaleidoscope/plugin/TriColor.h index 099fbc5b..83eebcf2 100644 --- a/src/kaleidoscope/plugin/TriColor.h +++ b/src/kaleidoscope/plugin/TriColor.h @@ -42,7 +42,7 @@ class TriColor : public Plugin, protected: - virtual void update(void) final; + void update(void) final; private: