plugin/PersistnetLEDMode: Use the new `onLEDModeChange()` hook

Signed-off-by: Gergely Nagy <algernon@keyboard.io>

src/kaleidoscope/plugin/PersistentLEDMode.cpp

@@ -33,8 +33,8 @@ EventHandlerResult PersistentLEDMode::onSetup() {
   Kaleidoscope.storage().get(settings_base_, cached_mode_index_);
 
   // If the index is max, assume an uninitialized EEPROM, and don't set the LED
-  // mode. We don't change the cached index here, `afterEachCycle()` will do
-  // that at the end of he cycle anyway.
+  // mode. We don't change the cached index here, `onLEDModeChange()` will do
+  // that whenever a led mode change happens.
   if (cached_mode_index_ != 0xff)
     return EventHandlerResult::OK;
 
@@ -43,7 +43,7 @@ EventHandlerResult PersistentLEDMode::onSetup() {
   return EventHandlerResult::OK;
 }
 
-EventHandlerResult PersistentLEDMode::afterEachCycle() {
+EventHandlerResult PersistentLEDMode::onLEDModeChange() {
   if (cached_mode_index_ == ::LEDControl.get_mode_index())
     return EventHandlerResult::OK;
 

src/kaleidoscope/plugin/PersistentLEDMode.h

@@ -16,11 +16,6 @@
  * this program. If not, see <http://www.gnu.org/licenses/>.
  */
 
-/* NOTE: This plugin is a workaround. It allows us to (optionally) save the LED
- * mode to storage, and restore it on next boot, without having a way to hook
- * into led mode change events. Once we can hook into that, this plugin shall be
- * reworked to use it instead of keeping `afterEachCycle()` busy. */
-
 #pragma once
 
 #include <Kaleidoscope.h>
@@ -33,7 +28,7 @@ class PersistentLEDMode: public kaleidoscope::Plugin {
   PersistentLEDMode() {}
 
   EventHandlerResult onSetup();
-  EventHandlerResult afterEachCycle();
+  EventHandlerResult onLEDModeChange();
  private:
   static uint16_t settings_base_;
   static uint8_t cached_mode_index_;