From 91e256a91387ea9bb2e8e31981f60f17e57db7ab Mon Sep 17 00:00:00 2001
From: Jesse Vincent <jesse@bestpractical.com>
Date: Tue, 26 Jan 2016 20:38:54 -0800
Subject: [PATCH] move the set_keymap conditional outside the set_keymap
 function

---
 KeyboardioFirmware.ino | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/KeyboardioFirmware.ino b/KeyboardioFirmware.ino
index 256f24ef..340084e2 100644
--- a/KeyboardioFirmware.ino
+++ b/KeyboardioFirmware.ino
@@ -11,7 +11,6 @@ LEDControl BlinkyLights;
 
 
 void set_keymap(Key keymapEntry, byte matrixStateEntry) {
-    if (keymapEntry.flags & SWITCH_TO_KEYMAP) {
         // this logic sucks. there is a better way TODO this
         if (! (keymapEntry.flags ^ ( MOMENTARY | SWITCH_TO_KEYMAP))) {
             if (key_toggled_on(matrixStateEntry)) {
@@ -34,7 +33,6 @@ void set_keymap(Key keymapEntry, byte matrixStateEntry) {
                 Storage.save_primary_keymap(primary_keymap);
             }
         }
-    }
 }
 
 void scan_matrix() {
@@ -138,8 +136,9 @@ void handle_key_event(byte row, byte col) {
 
     byte switchState = matrixState[row][col];
     Key mappedKey = keymaps[temporary_keymap][row][col];
-    set_keymap(keymaps[primary_keymap][row][col], switchState);
-
+    if (keymapEntry.flags & SWITCH_TO_KEYMAP) {
+        set_keymap(keymaps[primary_keymap][row][col], switchState);
+    }
     if (mappedKey.flags & SYNTHETIC_KEY) {
         handle_synthetic_key_press(switchState, mappedKey);
     } else {