From 91da0ae68e48f52ca4fb7e5908b02ab24d5a7577 Mon Sep 17 00:00:00 2001 From: Jesse Vincent Date: Sat, 3 Jun 2017 23:27:51 -0700 Subject: [PATCH] Make the linter happy --- src/Kaleidoscope-LEDControl.cpp | 8 ++++---- src/Kaleidoscope-LEDControl.h | 10 +++++----- src/LED-Off.h | 4 ++-- src/LEDUtils.cpp | 1 - 4 files changed, 11 insertions(+), 12 deletions(-) diff --git a/src/Kaleidoscope-LEDControl.cpp b/src/Kaleidoscope-LEDControl.cpp index be82deae..bdc76ba4 100644 --- a/src/Kaleidoscope-LEDControl.cpp +++ b/src/Kaleidoscope-LEDControl.cpp @@ -85,9 +85,9 @@ LEDControl_::mode_add(LEDMode *mode) { void LEDControl_::set_all_leds_to(uint8_t r, uint8_t g, uint8_t b) { cRGB color; - color.r=r; - color.g=g; - color.b=b; + color.r = r; + color.g = g; + color.b = b; set_all_leds_to(color); } @@ -217,7 +217,7 @@ LEDControl_::focusHook(const char *command) { LEDControl.next_mode(); Serial.read(); } else if (peek == 'p') { - // TODO + // TODO(algernon) Serial.read(); } else { uint8_t mode = Serial.parseInt(); diff --git a/src/Kaleidoscope-LEDControl.h b/src/Kaleidoscope-LEDControl.h index 45753748..6dbf92f7 100644 --- a/src/Kaleidoscope-LEDControl.h +++ b/src/Kaleidoscope-LEDControl.h @@ -4,16 +4,16 @@ #define LED_MAX_MODES 24 -#define LED_TOGGLE B00000001 // Synthetic, internal +#define LED_TOGGLE B00000001 // Synthetic, internal #define Key_LEDEffectNext (Key) { 0, KEY_FLAGS | SYNTHETIC | IS_INTERNAL | LED_TOGGLE } class LEDMode : public KaleidoscopePlugin { public: virtual void begin(void); - virtual void setup(void) {}; - virtual void init(void) {}; - virtual void update(void) {}; + virtual void setup(void) {} + virtual void init(void) {} + virtual void update(void) {} virtual void activate(void); }; @@ -21,7 +21,7 @@ class LEDControl_ : public KaleidoscopePlugin { public: LEDControl_(void); - virtual void begin(void) final; + void begin(void) final; static void next_mode(void); static void setup(void); diff --git a/src/LED-Off.h b/src/LED-Off.h index 6b1d1313..19d65cde 100644 --- a/src/LED-Off.h +++ b/src/LED-Off.h @@ -4,9 +4,9 @@ class LEDOff_ : public LEDMode { public: - LEDOff_(void) { }; + LEDOff_(void) { } - virtual void update(void) final; + void update(void) final; }; extern LEDOff_ LEDOff; diff --git a/src/LEDUtils.cpp b/src/LEDUtils.cpp index f67772db..7601ba3d 100644 --- a/src/LEDUtils.cpp +++ b/src/LEDUtils.cpp @@ -2,7 +2,6 @@ cRGB breath_compute() { - // This code is adapted from FastLED lib8tion.h as of dd5d96c6b289cb6b4b891748a4aeef3ddceaf0e6 // Eventually, we should consider just using FastLED