From 81d34bbd88e32258171896019a19f0419db267a4 Mon Sep 17 00:00:00 2001 From: Michael Richters Date: Wed, 13 Feb 2019 15:13:07 -0600 Subject: [PATCH] SpaceCadet: corrected bogus row & column info for injected keypress SpaceCadet was sending a keyswitch event with the row & column coordinates of the wrong key. The coordinates were coming from the keypress, but the injected event was for a previously-pressed (different) key that's still held. With the mutable `live_composite_keymap_[]` change, this meant that pressing (and holding) `shift` then another key would result in only a single character, rather than a repeating character. Regardless of the minor bug, using the row & col for the event was still logically incorrect here. Signed-off-by: Michael Richters --- src/kaleidoscope/plugin/SpaceCadet.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/kaleidoscope/plugin/SpaceCadet.cpp b/src/kaleidoscope/plugin/SpaceCadet.cpp index f248fd3a..315f9fda 100644 --- a/src/kaleidoscope/plugin/SpaceCadet.cpp +++ b/src/kaleidoscope/plugin/SpaceCadet.cpp @@ -130,7 +130,7 @@ EventHandlerResult SpaceCadet::onKeyswitchEvent(Key &mapped_key, byte row, byte //hit another key after this -- if it's a modifier, we want the modifier //key to be added to the report, for things like ctrl, alt, shift, etc) if (map[i].flagged) { - handleKeyswitchEvent(map[i].input, row, col, IS_PRESSED | INJECTED); + handleKeyswitchEvent(map[i].input, UNKNOWN_KEYSWITCH_LOCATION, IS_PRESSED | INJECTED); } //The keypress wasn't a match, so we need to mark it as not flagged and