From 7b49a2c011b3ca6fea46e963e034a7172f28cc31 Mon Sep 17 00:00:00 2001 From: Gergely Nagy Date: Tue, 15 May 2018 06:52:37 +0200 Subject: [PATCH] deprecations: Make some of them less scary By far the most common deprecation will be the event handler and loop hook deprecation. Make them less scary, and point out that unless one's a developer, they likely need not care. Signed-off-by: Gergely Nagy --- src/kaleidoscope_internal/deprecations.h | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/src/kaleidoscope_internal/deprecations.h b/src/kaleidoscope_internal/deprecations.h index d7dfddae..e1301c49 100644 --- a/src/kaleidoscope_internal/deprecations.h +++ b/src/kaleidoscope_internal/deprecations.h @@ -44,7 +44,11 @@ "Consider upgrading your plugins, or implementing the new interface\n" \ "described by `kaleidoscope::Plugin`. In particular, instead of using\n" \ "`Kaleidoscope.useEventHandlerHook`, implement the\n" \ - "`.onKeyswitchEvent()` method instead." + "`.onKeyswitchEvent()` method instead.\n" \ + "\n" \ + "If your plugins are up-to-date, and you are not a developer, it is\n" \ + "usually safe to ignore this message. Especally if the full error\n" \ + "points to a line containing `legacyLoopHook` or `legacyEventHandler`." #define _DEPRECATED_MESSAGE_LOOP_HOOK \ @@ -53,7 +57,12 @@ "Consider upgrading your plugins, or implementing the new interface\n" \ "described by `kaleidoscope::Plugin`. In particular, instead of using\n" \ "`Kaleidoscope.useLoopHook`, implement `.beforeEachCycle`,\n" \ - "`.beforeReportingState()`, or `.afterEachCycle()` instead." + "`.beforeReportingState()`, or `.afterEachCycle()` instead.\n" \ + "\n" \ + "If your plugins are up-to-date, and you are not a developer, it is\n" \ + "usually safe to ignore this message. Especally if the full error\n" \ + "points to a line containing `legacyLoopHook` or `legacyEventHandler`." + #define _DEPRECATED_MESSAGE_USE_INSTEAD(new_method) \ "Please use `" new_method "` instead."