Merge pull request #437 from keyboardio/various/idle-check-removal

Remove now-obsolete idle checks from a few plugins
pull/438/head
Jesse Vincent 6 years ago committed by GitHub
commit 758cf33c7d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

@ -85,13 +85,6 @@ EventHandlerResult Leader::onKeyswitchEvent(Key &mapped_key, byte row, byte col,
if (keyState & INJECTED) if (keyState & INJECTED)
return EventHandlerResult::OK; return EventHandlerResult::OK;
if (!keyIsPressed(keyState) && !keyWasPressed(keyState)) {
if (isLeader(mapped_key)) {
return EventHandlerResult::EVENT_CONSUMED;
}
return EventHandlerResult::OK;
}
if (!isActive() && !isLeader(mapped_key)) if (!isActive() && !isLeader(mapped_key))
return EventHandlerResult::OK; return EventHandlerResult::OK;

@ -116,9 +116,6 @@ EventHandlerResult OneShot::onKeyswitchEvent(Key &mapped_key, byte row, byte col
return EventHandlerResult::EVENT_CONSUMED; return EventHandlerResult::EVENT_CONSUMED;
} }
if (!keyIsPressed(keyState) && !keyWasPressed(keyState))
return EventHandlerResult::OK;
if (isOneShotKey(mapped_key)) { if (isOneShotKey(mapped_key)) {
if (isSticky_(idx)) { if (isSticky_(idx)) {
if (keyToggledOn(keyState)) { // maybe on _off instead? if (keyToggledOn(keyState)) { // maybe on _off instead?

@ -123,14 +123,6 @@ EventHandlerResult TapDance::onKeyswitchEvent(Key &mapped_key, byte row, byte co
if (keyState & INJECTED) if (keyState & INJECTED)
return EventHandlerResult::OK; return EventHandlerResult::OK;
if (!keyIsPressed(keyState) && !keyWasPressed(keyState)) {
if (isTapDance(mapped_key)) {
return EventHandlerResult::EVENT_CONSUMED;
}
return EventHandlerResult::OK;
}
if (!isTapDance(mapped_key)) { if (!isTapDance(mapped_key)) {
if (!isActive()) if (!isActive())
return EventHandlerResult::OK; return EventHandlerResult::OK;

Loading…
Cancel
Save