Clang doesn't like delete getting called on virtual classes without destructors.

src/kaleidoscope/simulator/actions/AssertLayerIsActive.h

@@ -48,6 +48,8 @@ class AssertLayerIsActive {
 
 public:
 
+      virtual ~Action() = default;
+
       Action(int layer_id) : layer_id_(layer_id) {}
 
       virtual void describe(const char *add_indent = "") const override {

src/kaleidoscope/simulator/actions/AssertTopActiveLayerIs.h

@@ -47,6 +47,8 @@ class AssertTopActiveLayerIs {
 
 public:
 
+        virtual ~Action() = default;
+
       Action(int layer_id) : layer_id_(layer_id) {}
 
       virtual void describe(const char *add_indent = "") const override {

src/kaleidoscope/simulator/actions/generic_report/GenerateHostEvent.h

@@ -58,6 +58,7 @@ class GenerateHostEvent {
   class Action : public interface::ReportAction<typename _ReportType::BaseReportType>,
       public HostEventAction {
 public:
+      virtual ~Action() = default;
 
       virtual void describe(const char *add_indent = "") const override {
         this->getSimulator()->log() << add_indent << "Generating host event";

src/kaleidoscope/simulator/interface/actions/AssertCycleIsNth.h

@@ -46,6 +46,8 @@ namespace interface {
 
        public:
 
+        virtual ~Action() = default;
+
         Action(int cycle_id) : cycle_id_(cycle_id) {}
 
         virtual void describe(const char *add_indent = "") const override {

src/kaleidoscope/simulator/interface/actions/AssertElapsedTimeGreater.h

@@ -48,6 +48,8 @@ namespace interface {
 
        public:
 
+        virtual ~Action() = default;
+
         Action(Simulator_::TimeType delta_t, Simulator_::TimeType start_t = 0)
           :  start_t_(start_t),
              delta_t_(delta_t)

src/kaleidoscope/simulator/interface/actions/AssertNumOverallReportsEquals.h

@@ -50,6 +50,8 @@ namespace interface {
 
        public:
 
+        virtual ~Action() = default;
+
         Action(int n_overall_reports)
           : n_overall_reports_(n_overall_reports) {}
 

src/kaleidoscope/simulator/interface/actions/CustomAction.h

@@ -50,6 +50,8 @@ namespace interface {
 
        public:
 
+        virtual ~Action() = default;
+
         Action(const std::function<bool()> &func)
           : func_(func)
         {}

src/kaleidoscope/simulator/interface/actions/generic_report/AssertCycleGeneratesNReports.h

@@ -50,6 +50,7 @@ namespace interface {
 
        public:
 
+        virtual ~Action() = default;
         Action(int n_reports) : n_reports_(n_reports) {}
 
         virtual void describe(const char *add_indent = "") const override {

src/kaleidoscope/simulator/interface/actions/generic_report/AssertReportEmpty.h

@@ -41,6 +41,8 @@ namespace interface {
 
        public:
 
+        virtual ~Action() = default;
+
         virtual void describe(const char *add_indent = "") const override {
           this->getSimulator()->log() << add_indent << "Report empty";
         }

src/kaleidoscope/simulator/interface/actions/generic_report/AssertReportEquals.h

@@ -57,6 +57,8 @@ namespace interface {
 
        public:
 
+        virtual ~Action() = default;
+
         Action(const _ReportType &report)
           :  report_(report)
         {}

src/kaleidoscope/simulator/interface/actions/generic_report/AssertReportIsNthInCycle.h

@@ -46,6 +46,8 @@ namespace interface {
 
        public:
 
+        virtual ~Action() = default;
+
         Action(int report_id) : report_id_(report_id) {}
 
         virtual void describe(const char *add_indent = "") const override {

src/kaleidoscope/simulator/interface/actions/generic_report/CustomReportAction.h

@@ -54,6 +54,8 @@ namespace interface {
 
         using ReportAction<_ReportType>::ActionBaseType;
 
+        virtual ~Action() = default;
+
         Action(const std::function<bool(const _ReportType&)> &func)
           : func_(func)
         {}

src/kaleidoscope/simulator/interface/actions/generic_report/DumpReport.h

@@ -41,6 +41,8 @@ namespace interface {
 
        public:
 
+        virtual ~Action() = default;
+
         virtual void describe(const char *add_indent = "") const override {
           this->getReport().dump(*this->getSimulator(), add_indent);
         }

src/kaleidoscope/simulator/interface/actions/generic_report/ReportAction.h

@@ -38,10 +38,12 @@ namespace interface {
 ///
     class ReportAction_ : public Action_ {
      public:
-
+     
       typedef Report_ ReportType;
       typedef ReportAction_ ActionBaseType;
 
+      virtual ~ReportAction_() = default; 
+
       virtual uint8_t getReportTypeId() const {
         return AnyTypeReportTypeId;
       }

src/kaleidoscope/simulator/interface/actions/keyboard_report/AssertAnyKeycodeActive.h

@@ -41,6 +41,8 @@ namespace interface {
 
        public:
 
+        virtual ~Action() = default;
+
         virtual void describe(const char *add_indent = "") const override {
           this->getSimulator()->log() << add_indent << "Any keycodes active";
         }

src/kaleidoscope/simulator/interface/actions/keyboard_report/AssertAnyModifierActive.h

@@ -41,6 +41,8 @@ namespace interface {
 
        public:
 
+        virtual ~Action() = default;
+
         virtual void describe(const char *add_indent = "") const override {
           this->getSimulator()->log() << add_indent << "Any modifiers active";
         }

src/kaleidoscope/simulator/interface/actions/keyboard_report/AssertKeycodesActive.h

@@ -77,6 +77,8 @@ namespace interface {
 
        public:
 
+        virtual ~Action() = default;
+
         Action(const std::vector<uint8_t> &keycodes,
                bool exclusively = false)
           :  keycodes_(keycodes),

src/kaleidoscope/simulator/interface/actions/keyboard_report/AssertModifiersActive.h

@@ -78,6 +78,9 @@ namespace interface {
 
        public:
 
+        virtual ~Action() = default;
+
+
         Action(const std::vector<uint8_t> &modifiers,
                bool exclusively = false)
           :  modifiers_(modifiers),