From 4f5413c9e523cc04f54fadb6b01913b4297aecb5 Mon Sep 17 00:00:00 2001 From: Michael Richters Date: Thu, 28 Jun 2018 13:51:31 -0500 Subject: [PATCH] Fix release of primary keycodes When a key was released, we were failing to send the release event explicitly. For most plugins, this didn't matter, but it was causing a problem for Leader, which acts on release events. By returning `EVENT_CONSUMED` instead of `OK`, we were stopping the release event from getting through to Leader, and thus a qukey with a Leader key as its primary keycode would fail. --- src/Kaleidoscope/Qukeys.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/Kaleidoscope/Qukeys.cpp b/src/Kaleidoscope/Qukeys.cpp index fce07fd7..18292dff 100644 --- a/src/Kaleidoscope/Qukeys.cpp +++ b/src/Kaleidoscope/Qukeys.cpp @@ -312,7 +312,8 @@ EventHandlerResult Qukeys::onKeyswitchEvent(Key &mapped_key, byte row, byte col, } flushQueue(queue_index); flushQueue(); - return EventHandlerResult::EVENT_CONSUMED; + mapped_key = getDualUsePrimaryKey(mapped_key); + return EventHandlerResult::OK; } // Otherwise, the key is still pressed