Merge pull request #247 from gedankenexperimenter/bug/shift-layer-release

Only call updateLiveCompositeKeymap() on key press; not release
pull/230/merge
Jesse Vincent 7 years ago committed by GitHub
commit 4bcbab2c09
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

@ -58,9 +58,9 @@ void handleKeyswitchEvent(Key mappedKey, byte row, byte col, uint8_t keyState) {
*/
if (row < ROWS && col < COLS) {
/* If a key had an on or off event, we update the live composite keymap. See
/* If a key had an on event, we update the live composite keymap. See
* layers.h for an explanation about the different caches we have. */
if (keyToggledOn(keyState) || keyToggledOff(keyState))
if (keyToggledOn(keyState))
Layer.updateLiveCompositeKeymap(row, col);
/* If the key we are dealing with is masked, ignore it until it is released.

@ -22,7 +22,7 @@ class Layer_ {
*
* At the same time, we want other keys to not be affected by the
* now-turned-off layer. So we update the keycode in the cache on-demand, when
* the key is pressed or released. (see the top of `handleKeyswitchEvent`).
* the key is pressed. (see the top of `handleKeyswitchEvent`).
*
* On the other hand, we also have plugins that scan the whole keymap, and do
* things based on that information, such as highlighting keys that changed

Loading…
Cancel
Save