From 29253a7d4c302f48ba460cd13a810c103f0b614a Mon Sep 17 00:00:00 2001 From: Jesse Vincent Date: Tue, 29 Jan 2019 15:48:01 -0800 Subject: [PATCH] Simplify function naming to remove all_lower option The google style allows all_lowercase names for things that are like accessors and mutators, but does not require it. I find that in our codebase, it just makes things look inconsistent Signed-off-by: Jesse Vincent --- doc/CODING_STYLE.md | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/doc/CODING_STYLE.md b/doc/CODING_STYLE.md index 8b28c9d0..7e6b2402 100644 --- a/doc/CODING_STYLE.md +++ b/doc/CODING_STYLE.md @@ -2022,7 +2022,7 @@ All such variables with static storage duration (i.e. statics and globals, see [ ### Function Names -> Regular functions have mixed case; accessors and mutators may be named like variables. +> Regular functions have mixed case Ordinarily, functions should start with a lower-case letter and have a capital letter for each new word (a.k.a. "[Camel Case][wikipedia:camel-case]" or "Pascal case"). Such names should not have underscores. Prefer to capitalize acronyms as single words (i.e. `startRpc()`, not `startRPC()`). @@ -2036,8 +2036,6 @@ openFileOrDie() (The same naming rule applies to class- and namespace-scope constants that are exposed as part of an API and that are intended to look like functions, because the fact that they're objects rather than functions is an unimportant implementation detail.) -Accessors and mutators (get and set functions) may be named like variables. These often correspond to actual member variables, but this is not required. For example, `int count()` and `void set_count(int count)`. - ### Namespace Names > Namespace names are all lower-case. Top-level namespace names are based on the project name . Avoid collisions between nested namespaces and well-known top-level namespaces.