cpplint: Mark some single-parameter constructors up for implicit conversion

For some of our single-parameter constructors, we _want_ to have implicit
conversions, because that makes the code more readable. Mark these up for
cpplint to ignore.

Signed-off-by: Gergely Nagy <algernon@keyboard.io>
pull/911/head
Gergely Nagy 4 years ago
parent 942e585c2b
commit 24a1d38eb1
No known key found for this signature in database
GPG Key ID: AC1E90BAC433F68F

@ -57,8 +57,8 @@ class MatrixAddr {
// ridiculously bad assembler code for each copy construction,
// that would bloat the default firmware by 1K of PROGMEM!
//
constexpr MatrixAddr(const ThisType &other) = default;
constexpr MatrixAddr(ThisType &&other) = default;
constexpr MatrixAddr(const ThisType &other) = default; // NOLINT(runtime/explicit)
constexpr MatrixAddr(ThisType &&other) = default; // NOLINT(runtime/explicit)
//constexpr MatrixAddr(const ThisType &other) : offset_(other.offset_) {}
//constexpr MatrixAddr(ThisType &&other) : offset_(other.offset_) {}

@ -36,7 +36,7 @@ class Key {
Key() = default;
constexpr Key(uint16_t raw)
constexpr Key(uint16_t raw) // NOLINT(runtime/explicit)
: Key{(uint8_t)(raw & 0x00FF), (uint8_t)(raw >> 8)}
{}
@ -140,7 +140,7 @@ class Key {
DataProxy() = default;
constexpr DataProxy(uint8_t value) : value_{value} {}
constexpr DataProxy(uint8_t value) : value_{value} {} // NOLINT(runtime/explicit)
DEPRECATED(DIRECT_KEY_MEMBER_ACCESS)
DataProxy &operator=(uint8_t value) {

Loading…
Cancel
Save