Merge pull request #489 from keyboardio/plugin/focus/explicit-serial-begin

Require an explicit Serial.begin() for Focus

src/kaleidoscope/Kaleidoscope.cpp

@@ -26,6 +26,16 @@ Kaleidoscope_::Kaleidoscope_(void) {
 
 void
 Kaleidoscope_::setup(void) {
+  // We are explicitly initializing the Serial port as early as possible to
+  // (temporarily, hopefully) work around an issue on OSX. If we initialize
+  // Serial too late, no matter what we do, we'll end up reading garbage from
+  // the serial port. For more information, see the following issue:
+  //   https://github.com/keyboardio/Kaleidoscope-Bundle-Keyboardio/pull/7
+  //
+  // TODO(anyone): Figure out a way we can get rid of this, and fix the bug
+  // properly.
+  Serial.begin(9600);
+
   kaleidoscope::Hooks::onSetup();
 
   KeyboardHardware.setup();

src/kaleidoscope/plugin/FocusSerial.h

@@ -85,10 +85,6 @@ class FocusSerial : public kaleidoscope::Plugin {
   static constexpr char SEPARATOR = ' ';
 
   /* Hooks */
-  EventHandlerResult onSetup() {
-    Serial.begin(9600);
-    return EventHandlerResult::OK;
-  }
   EventHandlerResult beforeReportingState();
   EventHandlerResult onFocusEvent(const char *command);