driver::storage::GD32Flash: Don't duplicate commit()

The class we're deriving from - `FlashAsEEPROM`'s `EEPROMClass` - already has a
`commit()` method, we do not need our own in the child class, especially not
when all it does is call the parent.

We previously added this call because in the original implementation of the
driver, we had an empty `commit()`. The correct fix is to remove the override,
rather than reimplement the inheritance.

Spotted by @obra, thanks!

Signed-off-by: Gergely Nagy <algernon@keyboard.io>
pull/1152/head
Gergely Nagy 3 years ago
parent c978eb8133
commit 22a6c092fc

@ -38,9 +38,6 @@ class GD32Flash : public EEPROMClass<_StorageProps::length> {
void setup() {
EEPROMClass<_StorageProps::length>::begin();
}
void commit() {
EEPROMClass<_StorageProps::length>::commit();
}
};
} // namespace storage

Loading…
Cancel
Save